Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MetaDataIndexStateServiceTests.testValidateShardLimit #47352

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

original-brownbear
Copy link
Member

The upper bound of nodes accepted by the method that's failing
here is 90, not 100 -> adjusted the limit in the test accordingly.

Closes #47351

The upper bound of nodes accepted by the method that's failing
here is `90`, not `100` -> adjusted the limit in the test accordingly.

Closes elastic#47351
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v8.0.0 v7.5.0 labels Oct 1, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the noise.

@original-brownbear
Copy link
Member Author

No worries, thanks for taking a look Gordon!

@original-brownbear original-brownbear merged commit f99096e into elastic:master Oct 1, 2019
@original-brownbear original-brownbear deleted the 47351 branch October 1, 2019 16:34
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Oct 1, 2019
)

The upper bound of nodes accepted by the method that's failing
here is `90`, not `100` -> adjusted the limit in the test accordingly.

Closes elastic#47351
@original-brownbear original-brownbear restored the 47351 branch January 6, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >test Issues or PRs that are addressing/adding tests v7.5.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI]Reproducible Failure in MetaDataIndexStateServiceTests.testValidateShardLimit
4 participants