SQL: Add support for shape type #46464
Conversation
Enables support for cartesian geometries shape type. We still need to decide how to handle the distance function since it is currently using the haversine distance formula and returns results in meters, which doesn't make any sense for cartesian geometries. Closes elastic#46412 Relates to elastic#43644
imotov
added
>enhancement
:Analytics/Geo
|
Pinging @elastic/es-search |
|
Pinging @elastic/es-analytics-geo |
| @@ -73,25 +73,25 @@ private static String createOGCIndexRequest() throws Exception { | |||
| createString("name", createIndex); | |||
There was a problem hiding this comment.
Since geo_shape support is still around, it would help to have both geo_shape and shape field types in the same dataset for both testing and example purposes. Unless I'm missing something it looks like all the geo_ fields were renamed.
There was a problem hiding this comment.
geo_shape and shape are both here to stay, they share pretty much most of the code paths, there is some test duplication between OGC tests and other tests, and shape implementation is much closer to OGC standard. So, I thought it just switching OGC test to shape would make sense and shouldn't reduce overall test coverage and we don't bloat the tests in the process.
There was a problem hiding this comment.
@costin does this makes sense, or should I make a copy of the tests for shape?
There was a problem hiding this comment.
@imotov A full copy is not needed however it would good to have a test that touches on a shape field (even if its just listing or doing a basic query) alongside a geo_shape.
|
@costin could you take another look? |
Enables support for Cartesian geometries shape type. We still need to
decide how to handle the distance function since it is currently using
the haversine distance formula and returns results in meters, which
doesn't make any sense for Cartesian geometries.
Closes #46412
Relates to #43644