Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Reformat update API reference. #45423

Merged
merged 4 commits into from
Aug 13, 2019
Merged

[DOCS] Reformat update API reference. #45423

merged 4 commits into from
Aug 13, 2019

Conversation

debadair
Copy link
Contributor

This PR updates the doc update API to align with the new API reference template.

Merge after #45415

Relates to elastic/docs#937 and #45365

@debadair debadair added >docs General docs changes WIP :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. labels Aug 10, 2019
@debadair debadair requested a review from jrodewig August 10, 2019 19:45
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@debadair debadair mentioned this pull request Aug 10, 2019
Closed
11 tasks
@debadair debadair removed the WIP label Aug 13, 2019
jrodewig
jrodewig reviewed Aug 13, 2019
View reviewed changes
docs/reference/docs/update.asciidoc Outdated


[[update-api-desc]]
==== {api-description-title}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be relocated between request and path parms.

jrodewig
jrodewig approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but we probably want to relocate the description before a merge.

@debadair debadair merged commit ac257db into elastic:master Aug 13, 2019
debadair added a commit that referenced this pull request Aug 22, 2019
@debadair
[DOCS] Reformat update API reference. (#45423)
7bf9651 
* [DOCS] Reformat update API reference.
debadair added a commit that referenced this pull request Aug 22, 2019
@debadair
[DOCS] Reformat update API reference. (#45423)
6c352ff 
* [DOCS] Reformat update API reference.
debadair added a commit that referenced this pull request Aug 22, 2019
@debadair
Revert "[DOCS] Reformat update API reference. (#45423)"
f2c5450 
This reverts commit 6c352ff.
debadair added a commit to debadair/elasticsearch that referenced this pull request Aug 23, 2019
@debadair
[DOCS] Reformat update API reference. (elastic#45423)
f053425 
* [DOCS] Reformat update API reference.
debadair added a commit that referenced this pull request Aug 23, 2019
@debadair
[DOCS] Backport reformat of doc update, delete, and get APIs (#45887)
e9b6fc8 
* [DOCS] Reformat get API. (#45416)

* [DOCS] Reformat get API.

* [DOCS] Reformat doc delete API reference. (#45422)

* [DOCS] Reformat doc delete API reference.

* [DOCS] Reformat update API reference. (#45423)

* [DOCS] Reformat update API reference.

* Fixed bad merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >docs General docs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@debadair @elasticmachine @jrodewig