Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Reformat doc delete API reference. #45422

Merged
merged 6 commits into from
Aug 13, 2019
Merged

Conversation

debadair
Copy link
Contributor

@debadair debadair commented Aug 10, 2019

@debadair debadair added the >docs General docs changes label Aug 10, 2019
@debadair debadair requested a review from jrodewig August 10, 2019 19:42
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@debadair debadair added :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. WIP labels Aug 10, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@debadair debadair removed the WIP label Aug 13, 2019

include::{docdir}/rest-api/common-parms.asciidoc[tag=doc-wait-for-active-shards]

[[docs-delete-api-desc]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be relocated below the request section but above the path parms section.

created before (check out the <<indices-create-index,create index API>>
for manually creating an index).
the delete operation automatically creates the specified index if it does not
exist. (For information about manually creating indices, see
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno if the parentheses are needed here.

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I'd move the description. Otherwise only a minor, non-blocking comment.

@debadair debadair merged commit 9f094d6 into elastic:master Aug 13, 2019
debadair added a commit that referenced this pull request Aug 22, 2019
* [DOCS] Reformat doc delete API reference.
debadair added a commit that referenced this pull request Aug 22, 2019
* [DOCS] Reformat doc delete API reference.
debadair added a commit that referenced this pull request Aug 22, 2019
debadair added a commit to debadair/elasticsearch that referenced this pull request Aug 23, 2019
* [DOCS] Reformat doc delete API reference.
debadair added a commit that referenced this pull request Aug 23, 2019
* [DOCS] Reformat get API. (#45416)

* [DOCS] Reformat get API.

* [DOCS] Reformat doc delete API reference. (#45422)

* [DOCS] Reformat doc delete API reference.

* [DOCS] Reformat update API reference. (#45423)

* [DOCS] Reformat update API reference.

* Fixed bad merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >docs General docs changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants