-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.x] Remove support for old translog checkpoint formats #44280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DaveCTurner, check this out. |
Hohol
changed the title
[7.x] Remove support for old checkpoint format
[7.x] Remove support for old translog checkpoint formats
Jul 12, 2019
polyfractal
added
:Distributed Indexing/Engine
Anything around managing Lucene and the Translog in an open shard.
>refactoring
labels
Jul 17, 2019
Pinging @elastic/es-distributed |
DaveCTurner
requested changes
Jul 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left minor suggestions.
server/src/test/java/org/elasticsearch/index/translog/TranslogTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/translog/TranslogTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/translog/TranslogTests.java
Outdated
Show resolved
Hide resolved
@elasticmachine test this please |
DaveCTurner
approved these changes
Jul 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pull bot
pushed a commit
to scher200/elasticsearch
that referenced
this pull request
Jul 19, 2019
This commit removes support for the translog checkpoint formats from versions before 6.4.0 since 8.0.0 is incompatible with indices from these versions. Relates elastic#44280 Fixes elastic#44210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Indexing/Engine
Anything around managing Lucene and the Translog in an open shard.
>refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for old translog checkpoint format.
Add unit test for Elasticsearch's behaviour with checkpoint files of old formats.
Issue: #44210