Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Remove support for old translog checkpoint formats #44280

Merged
merged 4 commits into from
Jul 19, 2019
Merged

[7.x] Remove support for old translog checkpoint formats #44280

merged 4 commits into from
Jul 19, 2019

Conversation

Hohol
Copy link
Contributor

@Hohol Hohol commented Jul 12, 2019

Remove support for old translog checkpoint format.
Add unit test for Elasticsearch's behaviour with checkpoint files of old formats.

Issue: #44210

@Hohol
Copy link
Contributor Author

Hohol commented Jul 12, 2019

@DaveCTurner, check this out.

@Hohol Hohol changed the title [7.x] Remove support for old checkpoint format [7.x] Remove support for old translog checkpoint formats Jul 12, 2019
@polyfractal polyfractal added :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >refactoring labels Jul 17, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left minor suggestions.

@DaveCTurner
Copy link
Contributor

@elasticmachine test this please

@DaveCTurner DaveCTurner self-requested a review July 19, 2019 12:45
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pull bot pushed a commit to scher200/elasticsearch that referenced this pull request Jul 19, 2019
This commit removes support for the translog checkpoint formats from versions
before 6.4.0 since 8.0.0 is incompatible with indices from these versions.

Relates elastic#44280
Fixes elastic#44210
@DaveCTurner DaveCTurner merged commit 804476c into elastic:7.x Jul 19, 2019
@Hohol Hohol deleted the old-checkpoints-7.x branch July 19, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants