Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for old translog checkpoint formats #44272

Merged
merged 7 commits into from
Jul 19, 2019
Merged

Remove support for old translog checkpoint formats #44272

merged 7 commits into from
Jul 19, 2019

Conversation

Hohol
Copy link
Contributor

@Hohol Hohol commented Jul 12, 2019 •
edited
Loading

Remove support for old translog checkpoint formats.
Add unit test for Elasticsearch's behaviour with checkpoint files of old formats.

Closes #44210

@Hohol
Copy link
Contributor Author

Hohol commented Jul 12, 2019

@DaveCTurner, am I on the right track? Is there anything else to be done in master (besides tests)?

@DaveCTurner
Copy link
Contributor

Yes that's about all that's needed for the production code in master, except that a few of the comments still mention version numbers or otherwise refer back to older versions. It's all about the tests :)

@DaveCTurner DaveCTurner self-requested a review July 12, 2019 11:08
@DaveCTurner DaveCTurner added :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 labels Jul 12, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@Hohol Hohol marked this pull request as ready for review July 12, 2019 12:36
DaveCTurner
DaveCTurner requested changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hohol looks good, but needs merging with latest master.

server/src/test/java/org/elasticsearch/index/translog/TranslogTests.java Outdated Show resolved Hide resolved
@DaveCTurner
Copy link
Contributor

@elasticmachine test this please

@Hohol @DaveCTurner
Fix filename typo
20cf66b 
Co-Authored-By: David Turner <[email protected]>
@Hohol
Copy link
Contributor Author

Hohol commented Jul 19, 2019

Forgot to actually change the file name...

@DaveCTurner
Copy link
Contributor

Oh hang on the build will still fail after renaming that file - try the :server:forbiddenpatterns task. Stand by I will work out what pattern would be acceptable.

@DaveCTurner
Copy link
Contributor

Please call it v2.ckp.binary.

@DaveCTurner
Copy link
Contributor

@elasticmachine test this please

@DaveCTurner DaveCTurner self-requested a review July 19, 2019 12:44
@DaveCTurner
Copy link
Contributor

@elasticmachine please run elasticsearch-ci/2

DaveCTurner
DaveCTurner approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit fd54e3e into elastic:master Jul 19, 2019
@Hohol Hohol deleted the old-checkpoints branch July 19, 2019 15:03
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees
No one assigned
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >refactoring v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support for old translog checkpoint formats
4 participants
@Hohol @DaveCTurner @elasticmachine @jakelandis