Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 7.1.1 and 6.8.1 versions #42253

Merged
merged 4 commits into from
May 21, 2019
Merged

add 7.1.1 and 6.8.1 versions #42253

merged 4 commits into from
May 21, 2019

Conversation

jakelandis
Copy link
Contributor

@jakelandis jakelandis commented May 20, 2019 •
edited
Loading

Related: #42240
Related: #42242
Related: #42251

@jakelandis jakelandis requested review from jasontedor and rjernst May 20, 2019 18:17
This was referenced May 20, 2019
Merged
Merged
Merged
jasontedor
jasontedor approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jakelandis
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/1
@elasticmachine run elasticsearch-ci/packaging-sample

@jakelandis
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/bwc
@elasticmachine run elasticsearch-ci/default-distro

@jakelandis
Copy link
Contributor Author

BWC failure is #42258 ... trying again

@elasticmachine run elasticsearch-ci/bwc

@polyfractal
Copy link
Contributor

Muted the date_histo bwc failure (570e8ed), as I suspect it will fail again :(

@jakelandis
Copy link
Contributor Author

Muted the date_histo bwc failure (570e8ed), as I suspect it will fail again :(

Indeed. Merged in master and trying again.

@jakelandis
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/2

@jakelandis
Copy link
Contributor Author

jakelandis commented May 21, 2019 •
edited
Loading

bwc failed [1], trying again.. (my local setup failed but for what appears to be a different reason)

@elasticmachine run elasticsearch-ci/bwc

[1] https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-bwc/5691/#showFailuresLink

    org.elasticsearch.upgrades.UpgradeClusterClientYamlTestSuiteIT.test {p0=mixed_cluster/40_ml_datafeed_crud/Test old cluster datafeed with aggs}
    org.elasticsearch.upgrades.UpgradeClusterClientYamlTestSuiteIT.test {p0=mixed_cluster/50_token_auth/Get the indexed token and use if to authenticate}
    org.elasticsearch.upgrades.UpgradeClusterClientYamlTestSuiteIT.test {p0=mixed_cluster/50_token_auth/Get the indexed refresh token and use it to get another access token and authenticate}
    org.elasticsearch.upgrades.UpgradeClusterClientYamlTestSuiteIT.test {p0=mixed_cluster/50_token_auth/Get the indexed refreshed access token and use if to authenticate}
    org.elasticsearch.upgrades.TokenBackwardsCompatibilityIT.testTokensStayInvalidatedInMixedCluster
    org.elasticsearch.upgrades.TokenBackwardsCompatibilityIT.testRefreshingTokensInMixedCluster
    org.elasticsearch.upgrades.TokenBackwardsCompatibilityIT.testGeneratingTokensInMixedCluster
    org.elasticsearch.upgrades.TokenBackwardsCompatibilityIT.testAccessTokensWorkInMixedCluster
    org.elasticsearch.upgrades.TokenBackwardsCompatibilityIT.testInvalidatingTokensInMixedCluster

@jakelandis
Copy link
Contributor Author

If the tests pass feel free to merge

@tvernum
Copy link
Contributor

tvernum commented May 21, 2019

The BWC failure in :x-pack:qa:rolling-upgrade looks real. I'm investigating.

@tvernum
Copy link
Contributor

tvernum commented May 21, 2019

The BWC failure is real, due to master and 7.x being out of sync after a backport. @jkakavas will fix.

@jkakavas
Copy link
Member

Sorry for the trouble, 49bd667 should fix this

@tvernum
Copy link
Contributor

tvernum commented May 21, 2019

I've merged master into this PR. With any luck the next build should be green.

@jkakavas
Copy link
Member

jkakavas commented May 21, 2019 •
edited
Loading 

"org.elasticsearch.smoketest.DocsClientYamlTestSuiteIT.test {yaml=reference/mapping/types/date_nanos/line_29}"

failed (gradle scan) but doesn't reproduce locally, I'll respin

@elasticmachine run elasticsearch-ci/1

@jkakavas
Copy link
Member

BWC failed now because of

elasticsearch/x-pack/qa/rolling-upgrade/src/test/java/org/elasticsearch/upgrades/RollupDateHistoUpgradeIT.java

Line 37 in 290c8b8

assumeTrue("DateHisto interval changed in 7.1", UPGRADE_FROM_VERSION.before(Version.V_8_0_0)); // TODO change this after backport

I'll push to master and here and re-spin this

@jkakavas
Copy link
Member

Looks like #39105

Failure: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-1/14172/

@elasticmachine run elasticsearch-ci/1

@alpar-t alpar-t merged commit e126d18 into elastic:master May 21, 2019
@henningandersen henningandersen mentioned this pull request May 21, 2019
Merged
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 21, 2019
@jasontedor
Merge remote-tracking branch 'elastic/master' into execute-actions-un…
fea358b 
…der-permit-primary-mode-only

* elastic/master:
  Move the FIPS configuration back to the build plugin (elastic#41989)
  Remove stray back tick that's messing up table format (elastic#41705)
  Add missing comma in code section (elastic#41678)
  add 7.1.1 and 6.8.1 versions (elastic#42253)
  Use spearate testkit dir for each run (elastic#42013)
  Add experimental and warnings to vector functions (elastic#42205)
  Fix version in tests since elastic#41906 was merged
  Bump version in BWC check after backport
  Prevent in-place downgrades and invalid upgrades (elastic#41731)
  Mute date_histo interval bwc test
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 21, 2019
@jasontedor
Merge branch 'master' into jdk-13-ci
c33cad7 
* master: (176 commits)
  Avoid unnecessary persistence of retention leases (elastic#42299)
  [ML][TEST] Fix limits in AutodetectMemoryLimitIT (elastic#42279)
  [ML Data Frame] Persist and restore checkpoint and position (elastic#41942)
  mute failing filerealm hash caching tests (elastic#42304)
  Safer Wait for Snapshot Success in ClusterPrivilegeTests (elastic#40943)
  Remove 7.0.2 (elastic#42282)
  Revert "Remove 7.0.2 (elastic#42282)"
  [DOCS] Copied note on slicing support to Slicing section. Closes 26114 (elastic#40426)
  Remove 7.0.2 (elastic#42282)
  Mute all ml_datafeed_crud rolling upgrade tests
  Move the FIPS configuration back to the build plugin (elastic#41989)
  Remove stray back tick that's messing up table format (elastic#41705)
  Add missing comma in code section (elastic#41678)
  add 7.1.1 and 6.8.1 versions (elastic#42253)
  Use spearate testkit dir for each run (elastic#42013)
  Add experimental and warnings to vector functions (elastic#42205)
  Fix version in tests since elastic#41906 was merged
  Bump version in BWC check after backport
  Prevent in-place downgrades and invalid upgrades (elastic#41731)
  Mute date_histo interval bwc test
  ...
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
@jakelandis
add 7.1.1 and 6.8.1 versions (elastic#42253)
6a0c9f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasontedor jasontedor jasontedor approved these changes

@rjernst rjernst Awaiting requested review from rjernst

Assignees
No one assigned
Labels
>non-issue v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jakelandis @polyfractal @tvernum @jkakavas @jasontedor @alpar-t