Use spearate testkit dir for each run #42013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Testkit reuses the teskit dir by default between tests. With this change we use a temporary one for each run hoping it will fix elastic#41431
alpar-t
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra |
mark-vieira
approved these changes
May 9, 2019
| @@ -86,6 +86,7 @@ public void testCurrentExamplePlugin() throws IOException { | |||
|
|
|||
| GradleRunner.create() | |||
| .withProjectDir(tmpDir.getRoot()) | |||
| .withTestKitDir(tmpDir.newFolder("testkit")) | |||
There was a problem hiding this comment.
This shouldn't be necessary. We are already running each of these test cases in a new temporary directory. By default TestKit is going to create a .gradle-test-kit directory under that folder. Really all this is doing is renaming that folder testkit instead. If the example plugin tests are failing, it's not due to testkit directory reuse.
|
|
||
| import java.util.Arrays; | ||
|
|
||
| public class TestClustersPluginIT extends GradleIntegrationTestCase { | ||
|
|
||
| private GradleRunner testclusters; |
There was a problem hiding this comment.
Can we rename this something more appropriate, like runner?
|
@elasticmachine run elasticsearch-ci/1 |
alpar-t
added a commit
that referenced
this pull request
May 21, 2019
Gradle Testkit reuses the teskit dir by default between tests. With this change we use a temporary one for each run hoping it will fix #41431
alpar-t
added a commit
that referenced
this pull request
May 21, 2019
Gradle Testkit reuses the teskit dir by default between tests. With this change we use a temporary one for each run hoping it will fix #41431
alpar-t
added a commit
that referenced
this pull request
May 21, 2019
Gradle Testkit reuses the teskit dir by default between tests. With this change we use a temporary one for each run hoping it will fix #41431
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 21, 2019
…der-permit-primary-mode-only * elastic/master: Move the FIPS configuration back to the build plugin (elastic#41989) Remove stray back tick that's messing up table format (elastic#41705) Add missing comma in code section (elastic#41678) add 7.1.1 and 6.8.1 versions (elastic#42253) Use spearate testkit dir for each run (elastic#42013) Add experimental and warnings to vector functions (elastic#42205) Fix version in tests since elastic#41906 was merged Bump version in BWC check after backport Prevent in-place downgrades and invalid upgrades (elastic#41731) Mute date_histo interval bwc test
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 21, 2019
* master: (176 commits) Avoid unnecessary persistence of retention leases (elastic#42299) [ML][TEST] Fix limits in AutodetectMemoryLimitIT (elastic#42279) [ML Data Frame] Persist and restore checkpoint and position (elastic#41942) mute failing filerealm hash caching tests (elastic#42304) Safer Wait for Snapshot Success in ClusterPrivilegeTests (elastic#40943) Remove 7.0.2 (elastic#42282) Revert "Remove 7.0.2 (elastic#42282)" [DOCS] Copied note on slicing support to Slicing section. Closes 26114 (elastic#40426) Remove 7.0.2 (elastic#42282) Mute all ml_datafeed_crud rolling upgrade tests Move the FIPS configuration back to the build plugin (elastic#41989) Remove stray back tick that's messing up table format (elastic#41705) Add missing comma in code section (elastic#41678) add 7.1.1 and 6.8.1 versions (elastic#42253) Use spearate testkit dir for each run (elastic#42013) Add experimental and warnings to vector functions (elastic#42205) Fix version in tests since elastic#41906 was merged Bump version in BWC check after backport Prevent in-place downgrades and invalid upgrades (elastic#41731) Mute date_histo interval bwc test ...
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Gradle Testkit reuses the teskit dir by default between tests. With this change we use a temporary one for each run hoping it will fix elastic#41431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle Testkit reuses the teskit dir by default between tests.
With this change we use a temporary one for each run
hoping it will fix #41431