SQL: fix object extraction from sources #37502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throws an exception if hit extractor tries to retrieve unsupported
object. For example, selecting "a" from `{"a": {"b": "c"}}` now throws
an exception instead of returning null.
Relates to elastic#37364
|
Pinging @elastic/es-search |
|
@elasticmachine run elasticsearch-ci-1 |
|
run the gradle build tests 1 |
|
run the gradle build tests 2 |
1 similar comment
|
run the gradle build tests 2 |
|
run the gradle build tests 1 |
matriv
reviewed
Jan 16, 2019
| public void testObjectsForSourceValue() throws IOException { | ||
| String fieldName = randomAlphaOfLength(5); | ||
| FieldHitExtractor fe = new FieldHitExtractor(fieldName, null, false); | ||
| SearchHit hit = new SearchHit(1); |
There was a problem hiding this comment.
Why did you choose to call extract(hit) and not follow the approach as here for example: https://github.com/elastic/elasticsearch/pull/37502/files#diff-9aaee9be08445653bba7407b9f2b5ca3R302
There was a problem hiding this comment.
No particular reason. Both approaches would work I think. I can replace it if you prefer.
There was a problem hiding this comment.
Nevermind, just wanted to check if there was a particular reason.
|
run the gradle build tests 1 |
1 similar comment
|
run the gradle build tests 1 |
|
run the gradle build tests 1 |
|
run the gradle build tests 2 |
|
run the gradle build tests 1 |
|
run the gradle build tests 1 |
imotov
added a commit
that referenced
this pull request
Jan 18, 2019
Throws an exception if hit extractor tries to retrieve unsupported
object. For example, selecting "a" from `{"a": {"b": "c"}}` now throws
an exception instead of returning null.
Relates to #37364
imotov
added a commit
that referenced
this pull request
Jan 18, 2019
Throws an exception if hit extractor tries to retrieve unsupported
object. For example, selecting "a" from `{"a": {"b": "c"}}` now throws
an exception instead of returning null.
Relates to #37364
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 21, 2019
* elastic/master: (104 commits) Permission for restricted indices (elastic#37577) Remove Watcher Account "unsecure" settings (elastic#36736) Add cache cleaning task for ML snapshot (elastic#37505) Update jdk used by the docker builds (elastic#37621) Remove an unused constant in PutMappingRequest. Update get users to allow unknown fields (elastic#37593) Do not add index event listener if CCR disabled (elastic#37432) Add local session timeouts to leader node (elastic#37438) Add some deprecation optimizations (elastic#37597) refactor inner geogrid classes to own class files (elastic#37596) Remove obsolete deprecation checks (elastic#37510) ML: Add support for single bucket aggs in Datafeeds (elastic#37544) ML: creating ML State write alias and pointing writes there (elastic#37483) Deprecate types in the put mapping API. (elastic#37280) [ILM] Add unfollow action (elastic#36970) Packaging: Update marker used to allow ELASTIC_PASSWORD (elastic#37243) Fix setting openldap realm ssl config Document the need for JAVA11_HOME (elastic#37589) SQL: fix object extraction from sources (elastic#37502) Nit in settings.gradle for Eclipse ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws an exception if hit extractor tries to retrieve unsupported
object. For example, selecting "a" from
{"a": {"b": "c"}}now throwsan exception instead of returning null.
Relates to #37364