Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging: Update marker used to allow ELASTIC_PASSWORD #37243

Merged
merged 3 commits into from
Jan 18, 2019

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Jan 8, 2019

This commit updates the file docker's entrypoint script looks for when
deciding to process the ELASTIC_PASSWORD env var. The x-pack subdir
of bin no longer exists in 7.0, where the backcompat layer for x-pack
script locations was removed.

closes #37240

This commit updates the file docker's entrypoint script looks for when
deciding to process the ELASTIC_PASSWORD env var. The x-pack subdir
of bin no longer exists in 7.0, where the backcompat layer for x-pack
script locations was removed.

closes elastic#37240
@rjernst rjernst added >bug :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v7.0.0 labels Jan 8, 2019
@rjernst rjernst requested a review from jasontedor January 8, 2019 23:00
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@rjernst
Copy link
Member Author

rjernst commented Jan 8, 2019

@elasticmachine run gradle build tests 1

Copy link
Contributor

@alpar-t alpar-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Would be nice to add some tests to make sure this works.
The testfixtures plugin with docker-compose would make the startup part fairly straight forward and we would only need a test to make sure we can connect with the specific user.
We should aim to reach a decision on how we want to test the docker images so PRs like these can be accompanied by tests.

@alpar-t
Copy link
Contributor

alpar-t commented Jan 12, 2019

@elasticmachine run all packaging tests

@rjernst
Copy link
Member Author

rjernst commented Jan 18, 2019

Per discussion with @atorok I have spun off the need for docker tests into a separate issue: #37617.

@rjernst rjernst merged commit a2bdfb9 into elastic:master Jan 18, 2019
@rjernst rjernst deleted the docker_password branch January 18, 2019 19:49
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 21, 2019
* elastic/master: (104 commits)
  Permission for restricted indices (elastic#37577)
  Remove Watcher Account "unsecure" settings (elastic#36736)
  Add cache cleaning task for ML snapshot (elastic#37505)
  Update jdk used by the docker builds (elastic#37621)
  Remove an unused constant in PutMappingRequest.
  Update get users to allow unknown fields (elastic#37593)
  Do not add index event listener if CCR disabled (elastic#37432)
  Add local session timeouts to leader node (elastic#37438)
  Add some deprecation optimizations (elastic#37597)
  refactor inner geogrid classes to own class files (elastic#37596)
  Remove obsolete deprecation checks (elastic#37510)
  ML: Add support for single bucket aggs in Datafeeds (elastic#37544)
  ML: creating ML State write alias and pointing writes there (elastic#37483)
  Deprecate types in the put mapping API. (elastic#37280)
  [ILM] Add unfollow action (elastic#36970)
  Packaging: Update marker used to allow ELASTIC_PASSWORD (elastic#37243)
  Fix setting openldap realm ssl config
  Document the need for JAVA11_HOME (elastic#37589)
  SQL: fix object extraction from sources (elastic#37502)
  Nit in settings.gradle for Eclipse
  ...
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set the elasticsearch bootstrap password in docker using environment variable.
5 participants