Remove unsupported Version.V_5_* #32937

jimczi · 2018-08-17T10:32:17Z

This change removes the es 5x version constants and their usages.

jpountz

Awesome! I left some comments.

jpountz · 2018-08-17T11:40:26Z

buildSrc/src/main/groovy/org/elasticsearch/gradle/VersionCollection.groovy

+        if (res.isEmpty() && nextMajorVersion == 6) {
+            // bwc for v5
+            return Version.fromString("5.6.11")
+        }


why do we need this?

Since v7 is not released VersionCollection tries to find the last major before v6. I am not happy with this change though so I added a null version in Version.java to reference V5_6_11:
https://github.com/elastic/elasticsearch/pull/32937/files#diff-818e36d28dd050223297d06218747cbe . This line is then parsed by the regex in build.gradle and correctly reference a v5 release.

jpountz · 2018-08-17T11:49:47Z

...reindex/src/test/java/org/elasticsearch/index/reindex/remote/RemoteRequestBuildersTests.java

@@ -136,13 +135,13 @@ public void testInitialSearchParamsFields() {
        // Test stored_fields for versions that support it
        searchRequest = new SearchRequest().source(new SearchSourceBuilder());
        searchRequest.source().storedField("_source").storedField("_id");
-        remoteVersion = Version.fromId(between(Version.V_5_0_0_alpha4_ID, Version.CURRENT.id));
+        remoteVersion = Version.fromId(between(5000004, Version.CURRENT.id));


can you add the version it maps to as a comment?

jpountz · 2018-08-17T11:49:55Z

...reindex/src/test/java/org/elasticsearch/index/reindex/remote/RemoteRequestBuildersTests.java

        assertThat(initialSearch(searchRequest, query, remoteVersion).getParameters(), hasEntry("stored_fields", "_source,_id"));

        // Test fields for versions that support it
        searchRequest = new SearchRequest().source(new SearchSourceBuilder());
        searchRequest.source().storedField("_source").storedField("_id");
-        remoteVersion = Version.fromId(between(2000099, Version.V_5_0_0_alpha4_ID - 1));
+        remoteVersion = Version.fromId(between(2000099, 5000003));


jpountz · 2018-08-17T11:50:56Z

...dex/src/test/java/org/elasticsearch/index/reindex/remote/RemoteScrollableHitSourceTests.java

@@ -150,13 +150,13 @@ public void testLookupRemoteVersion() throws Exception {
        assertTrue(called.get());
        called.set(false);
        sourceWithMockedRemoteCall(false, ContentType.APPLICATION_JSON, "main/5_0_0_alpha_3.json").lookupRemoteVersion(v -> {
-            assertEquals(Version.V_5_0_0_alpha3, v);
+            assertEquals(Version.fromId(5000003), v);


can you add a comment about the version it maps to?

jpountz · 2018-08-17T11:51:03Z

...dex/src/test/java/org/elasticsearch/index/reindex/remote/RemoteScrollableHitSourceTests.java

            called.set(true);
        });
        assertTrue(called.get());
        called.set(false);
        sourceWithMockedRemoteCall(false, ContentType.APPLICATION_JSON, "main/with_unknown_fields.json").lookupRemoteVersion(v -> {
-            assertEquals(Version.V_5_0_0_alpha3, v);
+            assertEquals(Version.fromId(5000003), v);


jpountz · 2018-08-17T12:00:52Z

server/src/main/java/org/elasticsearch/index/query/SimpleQueryStringBuilder.java

        out.writeBoolean(settings.lenient());
-        if (out.getVersion().onOrAfter(Version.V_5_1_1)) {
-            out.writeBoolean(lenientSet);


keep this one?

jpountz · 2018-08-17T12:02:01Z

server/src/main/java/org/elasticsearch/persistent/PersistentTasksCustomMetaData.java

@@ -188,7 +188,7 @@ public long getNumberOfTasksOnNode(String nodeId, String taskName) {

    @Override
    public Version getMinimalSupportedVersion() {
-        return Version.V_5_4_0;
+        return Version.V_6_0_0_alpha1;


return Version.CURRENT.minimumCompatibilityVersion(); ?

jpountz · 2018-08-17T12:12:07Z

server/src/test/java/org/elasticsearch/index/shard/ShardGetServiceTests.java

@@ -82,7 +82,7 @@ public void testGetForUpdateWithParentField() throws IOException {
        Settings settings = Settings.builder().put(IndexMetaData.SETTING_VERSION_CREATED, Version.CURRENT)
            .put(IndexMetaData.SETTING_NUMBER_OF_REPLICAS, 1)
            .put(IndexMetaData.SETTING_NUMBER_OF_SHARDS, 1)
-            .put("index.version.created", Version.V_5_6_0) // for parent field mapper
+            .put("index.version.created", Version.V_6_0_0) // for parent field mapper


I thought _parent wouldn't be allowed on 6.0?

jpountz · 2018-08-17T12:15:05Z

...rc/main/java/org/elasticsearch/xpack/core/ml/job/process/autodetect/state/ModelSnapshot.java

-        // no model changes between 5.5.0 and 6.3.0.
-        private Version minVersion = Version.V_5_5_0;
+        // value for min_version.
+        private Version minVersion = Version.V_6_3_0;


why not 6.0.0 or Version.CURRENT.minCompatibilityVersion()?

jpountz · 2018-08-17T12:20:55Z

...ck/protocol/src/main/java/org/elasticsearch/protocol/xpack/ml/job/process/ModelSnapshot.java

-        // no model changes between 5.5.0 and 6.3.0.
-        private Version minVersion = Version.V_5_5_0;
+        // value for min_version.
+        private Version minVersion = Version.V_6_3_0;


why not 6.0.0? I suspect it says 6.3.0 just because it was the latest version at the time this comment was written

The comment is truncated, it says:

// Stored snapshot documents created prior to 6.3.0 will have no // value for min_version.

I'll put it on a single line.

jimczi · 2018-08-17T18:16:51Z

server/src/main/java/org/elasticsearch/Version.java

+     * DO NOT USE: We need to keep this version around until we release the first
+     * version of 7. The list of supported versions is extracted from this file with a regex (see build.gradle)
+     * but v7 is not released yet so we search the latest release before v6.
+     **/


I had to keep this version around to make VersionCollection happy but that doesn't sound right. The mixed cluster tests still try to spawn v5.6 nodes where I'd expect 6x and 7x only. @rjernst @hub-cap can you take a look ?

On master there should not be any uses of 5.6.11 by the build, since we do not support any kind of upgrade between the two (rolling or full cluster restart). Can you provide a gist with the failure from the gradle side when this constant is not present?

It fails with:

* Where: Build file '/Users/jimczi/Projects/elasticsearch/build.gradle' line: 111 * What went wrong: A problem occurred evaluating root project 'elasticsearch'. > java.util.NoSuchElementException (no error message)

The NoSuchElementException is thrown when VersionCollection ctr calls getHighestPreviousMinor.

Can you run it with --stacktrace and paste a gist here?

sure:

* Where: Build file '/Users/jimczi/Projects/elasticsearch/build.gradle' line: 111 * What went wrong: A problem occurred evaluating root project 'elasticsearch'. > java.util.NoSuchElementException (no error message) * Try: Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Exception is: org.gradle.api.GradleScriptException: A problem occurred evaluating root project 'elasticsearch'. at org.gradle.groovy.scripts.internal.DefaultScriptRunnerFactory$ScriptRunnerImpl.run(DefaultScriptRunnerFactory.java:92) at org.gradle.configuration.DefaultScriptPluginFactory$ScriptPluginImpl$2.run(DefaultScriptPluginFactory.java:204) at org.gradle.configuration.ProjectScriptTarget.addConfiguration(ProjectScriptTarget.java:77) at org.gradle.configuration.DefaultScriptPluginFactory$ScriptPluginImpl.apply(DefaultScriptPluginFactory.java:209) at org.gradle.configuration.BuildOperationScriptPlugin$1.run(BuildOperationScriptPlugin.java:61) at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:300) at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:292) at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:174) at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90) at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31) at org.gradle.configuration.BuildOperationScriptPlugin.apply(BuildOperationScriptPlugin.java:58) at org.gradle.configuration.project.BuildScriptProcessor.execute(BuildScriptProcessor.java:41) at org.gradle.configuration.project.BuildScriptProcessor.execute(BuildScriptProcessor.java:26) at org.gradle.configuration.project.ConfigureActionsProjectEvaluator.evaluate(ConfigureActionsProjectEvaluator.java:34) at org.gradle.configuration.project.LifecycleProjectEvaluator$EvaluateProject.run(LifecycleProjectEvaluator.java:105) at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:300) at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:292) at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:174) at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90) at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31) at org.gradle.configuration.project.LifecycleProjectEvaluator.evaluate(LifecycleProjectEvaluator.java:68) at org.gradle.api.internal.project.DefaultProject.evaluate(DefaultProject.java:682) at org.gradle.api.internal.project.DefaultProject.evaluate(DefaultProject.java:138) at org.gradle.execution.TaskPathProjectEvaluator.configure(TaskPathProjectEvaluator.java:35) at org.gradle.execution.TaskPathProjectEvaluator.configureHierarchy(TaskPathProjectEvaluator.java:60) at org.gradle.configuration.DefaultBuildConfigurer.configure(DefaultBuildConfigurer.java:41) at org.gradle.initialization.DefaultGradleLauncher$ConfigureBuild.run(DefaultGradleLauncher.java:266) at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:300) at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:292) at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:174) at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90) at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31) at org.gradle.initialization.DefaultGradleLauncher.configureBuild(DefaultGradleLauncher.java:179) at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:138) at org.gradle.initialization.DefaultGradleLauncher.executeTasks(DefaultGradleLauncher.java:121) at org.gradle.internal.invocation.GradleBuildController$1.call(GradleBuildController.java:77) at org.gradle.internal.invocation.GradleBuildController$1.call(GradleBuildController.java:74) at org.gradle.internal.work.DefaultWorkerLeaseService.withLocks(DefaultWorkerLeaseService.java:152) at org.gradle.internal.work.StopShieldingWorkerLeaseService.withLocks(StopShieldingWorkerLeaseService.java:38) at org.gradle.internal.invocation.GradleBuildController.doBuild(GradleBuildController.java:96) at org.gradle.internal.invocation.GradleBuildController.run(GradleBuildController.java:74) at org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28) at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35) at org.gradle.tooling.internal.provider.ValidatingBuildActionRunner.run(ValidatingBuildActionRunner.java:32) at org.gradle.launcher.exec.RunAsBuildOperationBuildActionRunner$3.run(RunAsBuildOperationBuildActionRunner.java:47) at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:300) at org.gradle.internal.operations.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:292) at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:174) at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:90) at org.gradle.internal.operations.DelegatingBuildOperationExecutor.run(DelegatingBuildOperationExecutor.java:31) at org.gradle.launcher.exec.RunAsBuildOperationBuildActionRunner.run(RunAsBuildOperationBuildActionRunner.java:43) at org.gradle.tooling.internal.provider.SubscribableBuildActionRunner.run(SubscribableBuildActionRunner.java:51) at org.gradle.launcher.exec.InProcessBuildActionExecuter$1.transform(InProcessBuildActionExecuter.java:50) at org.gradle.launcher.exec.InProcessBuildActionExecuter$1.transform(InProcessBuildActionExecuter.java:46) at org.gradle.composite.internal.DefaultRootBuildState.run(DefaultRootBuildState.java:74) at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:46) at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:32) at org.gradle.launcher.exec.BuildTreeScopeBuildActionExecuter.execute(BuildTreeScopeBuildActionExecuter.java:39) at org.gradle.launcher.exec.BuildTreeScopeBuildActionExecuter.execute(BuildTreeScopeBuildActionExecuter.java:25) at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:80) at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:53) at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:62) at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:34) at org.gradle.tooling.internal.provider.GradleThreadBuildActionExecuter.execute(GradleThreadBuildActionExecuter.java:36) at org.gradle.tooling.internal.provider.GradleThreadBuildActionExecuter.execute(GradleThreadBuildActionExecuter.java:25) at org.gradle.tooling.internal.provider.ParallelismConfigurationBuildActionExecuter.execute(ParallelismConfigurationBuildActionExecuter.java:43) at org.gradle.tooling.internal.provider.ParallelismConfigurationBuildActionExecuter.execute(ParallelismConfigurationBuildActionExecuter.java:29) at org.gradle.tooling.internal.provider.StartParamsValidatingActionExecuter.execute(StartParamsValidatingActionExecuter.java:59) at org.gradle.tooling.internal.provider.StartParamsValidatingActionExecuter.execute(StartParamsValidatingActionExecuter.java:31) at org.gradle.tooling.internal.provider.SessionFailureReportingActionExecuter.execute(SessionFailureReportingActionExecuter.java:59) at org.gradle.tooling.internal.provider.SessionFailureReportingActionExecuter.execute(SessionFailureReportingActionExecuter.java:44) at org.gradle.tooling.internal.provider.SetupLoggingActionExecuter.execute(SetupLoggingActionExecuter.java:46) at org.gradle.tooling.internal.provider.SetupLoggingActionExecuter.execute(SetupLoggingActionExecuter.java:30) at org.gradle.launcher.daemon.server.exec.ExecuteBuild.doBuild(ExecuteBuild.java:67) at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36) at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:122) at org.gradle.launcher.daemon.server.exec.WatchForDisconnection.execute(WatchForDisconnection.java:37) at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:122) at org.gradle.launcher.daemon.server.exec.ResetDeprecationLogger.execute(ResetDeprecationLogger.java:26) at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:122) at org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon.execute(RequestStopIfSingleUsedDaemon.java:34) at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:122) at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:74) at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:72) at org.gradle.util.Swapper.swap(Swapper.java:38) at org.gradle.launcher.daemon.server.exec.ForwardClientInput.execute(ForwardClientInput.java:72) at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:122) at org.gradle.launcher.daemon.server.exec.LogAndCheckHealth.execute(LogAndCheckHealth.java:50) at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:122) at org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(LogToClient.java:62) at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36) at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:122) at org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment.doBuild(EstablishBuildEnvironment.java:82) at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36) at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:122) at org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespondWithBusy.java:50) at org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:295) at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63) at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46) at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55) Caused by: java.util.NoSuchElementException at java_util_SortedSet$last.call(Unknown Source) at org.elasticsearch.gradle.VersionCollection.getHighestPreviousMinor(VersionCollection.groovy:296) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at org.elasticsearch.gradle.VersionCollection.<init>(VersionCollection.groovy:142) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at build_5ys12t32hufwlh0gq31qqnlig.run(/Users/jimczi/Projects/elasticsearch/build.gradle:111) at org.gradle.groovy.scripts.internal.DefaultScriptRunnerFactory$ScriptRunnerImpl.run(DefaultScriptRunnerFactory.java:90) ... 99 more ```

I think we just want to set maintenanceBugfixSnapshot to null in this case, because the outer block that is within is for master, where it does not make sense to reference the maintenance version (eg 5.6.11) ever, since there should be no uses by bwc tests. Can you try changing line 141-143 of VersionCollection to just set it to null?

Thanks, it seems to work so I pushed the changes, let's see if the build passes.

The mixed cluster tests starts a v5.6 node which fails the handshake with the other v6 nodes. I don't understand why it uses a 5x node since all references to v5 are now removed. Did I miss something ?

This does seem odd. I think @hub-cap needs to take a look at this too.

Sorry the mixed cluster tests are fine (they start a mix of v6.5 and v7 nodes now) but they fail the handshake. I talked to @s1monw which pointed out that we also need to force the minimum compatibility of version 6 to the removed v5.6 series. I pushed the fix and all tests pass locally :)

elasticmachine · 2018-08-20T07:45:49Z

Pinging @elastic/es-search-aggs

…6.x versions

jpountz

VersionCollection might need more eyes, the rest LGTM.

jimczi · 2018-08-23T09:22:06Z

Thanks @jpountz , @s1monw could you take a look at the Version and VersionCollection changes ?

s1monw

left 2 question LGTM otherwise

s1monw · 2018-08-23T11:59:42Z

server/src/main/java/org/elasticsearch/Version.java

@@ -629,7 +475,10 @@ public boolean isRelease() {
            }
            assert field.getName().matches("V(_\\d+)+(_(alpha|beta|rc)\\d+)?") : field.getName();
            try {
-                versions.add(((Version) field.get(null)));
+                // special case for V_5_6_11
+                if (field.get(null) != null) {


I am not sure I am following can you leave a comment what this actually does?

This is a leftover, I removed it thanks

s1monw · 2018-08-23T12:00:01Z

buildSrc/src/main/groovy/org/elasticsearch/gradle/VersionCollection.groovy

@@ -140,7 +140,11 @@ class VersionCollection {
                    }
                    // caveat 0 - now dip back 2 versions to get the last supported snapshot version of the line
                    Version highestMinor = getHighestPreviousMinor(currentVersion.major - 1)
-                    maintenanceBugfixSnapshot = replaceAsSnapshot(highestMinor)
+                    if (highestMinor == null) {


is this a pre-existing bug?

Yes. Though maintenanceBugfixSnapshot should always be null in this case so I pushed 40d70b4

* master: Add hook to skip asserting x-content equivalence (#33114) Muted testListenersThrowingExceptionsDoNotCauseOtherListenersToBeSkipped [Rollup] Move getMetadata() methods out of rollup config objects (#32579) Muted testEmptyAuthorizedIndicesSearchForAllDisallowNoIndices Update Google Cloud Storage Library for Java (#32940) Remove unsupported Version.V_5_* (#32937)

* ccr: Add hook to skip asserting x-content equivalence (elastic#33114) Muted testListenersThrowingExceptionsDoNotCauseOtherListenersToBeSkipped [Rollup] Move getMetadata() methods out of rollup config objects (elastic#32579) fixed not returning response instance Muted testEmptyAuthorizedIndicesSearchForAllDisallowNoIndices Update Google Cloud Storage Library for Java (elastic#32940) Remove unsupported Version.V_5_* (elastic#32937)

* ccr: (71 commits) Make CCR QA tests build again (elastic#33113) Add hook to skip asserting x-content equivalence (elastic#33114) Muted testListenersThrowingExceptionsDoNotCauseOtherListenersToBeSkipped [Rollup] Move getMetadata() methods out of rollup config objects (elastic#32579) fixed not returning response instance Muted testEmptyAuthorizedIndicesSearchForAllDisallowNoIndices Update Google Cloud Storage Library for Java (elastic#32940) Remove unsupported Version.V_5_* (elastic#32937) Required changes after merging in master branch. [DOCS] Add docs for Application Privileges (elastic#32635) Add versions 5.6.12 and 6.4.1 Do NOT allow termvectors on nested fields (elastic#32728) [Rollup] Return empty response when aggs are missing (elastic#32796) [TEST] Add some ACL yaml tests for Rollup (elastic#33035) Move non duplicated actions back into xpack core (elastic#32952) Test fix - GraphExploreResponseTests should not randomise array elements Closes elastic#33086 Use `addIfAbsent` instead of checking if an element is contained TESTS: Fix Random Fail in MockTcpTransportTests (elastic#33061) HLRC: Fix Compile Error From Missing Throws (elastic#33083) [DOCS] Remove reload password from docs cf. elastic#32889 ...

Remove unsupported Version.V_5_*

2160102

This change removes the es 5x version constants and their usages.

jimczi added >non-issue >upgrade labels Aug 17, 2018

jimczi mentioned this pull request Aug 17, 2018

Lucene 8 upgrade checklist #32899

Closed

18 tasks

jpountz reviewed Aug 17, 2018

View reviewed changes

jimczi added 5 commits August 17, 2018 16:05

address reviews and fix uts

18c82ef

add missing change

db034af

remove unused import and some version beta checks

9310aed

precommit passes

dfb2f34

Merge branch 'master' into version5_removal

66d613a

jimczi commented Aug 17, 2018

View reviewed changes

set maintenanceBugfixSnapshot to null when the previous major is unknown

03b8fe1

colings86 added the :Search/Search Search-related issues that do not fall into other categories label Aug 20, 2018

jimczi added 5 commits August 20, 2018 14:10

hardcode minimum version compatibility of version 6 to the removed 5.…

42d237d

…6.x versions

adapt versions uts

faf42cc

Merge branch 'master' into version5_removal

f65a2b7

fix upgrade minimum compatibility version

fefd689

Merge branch 'master' into version5_removal

50d9ef8

jimczi added the v7.0.0 label Aug 21, 2018

jpountz approved these changes Aug 23, 2018

View reviewed changes

s1monw approved these changes Aug 23, 2018

View reviewed changes

jimczi added 6 commits August 23, 2018 14:31

remove unneeded change

fac4e45

cleanup

40d70b4

Merge branch 'master' into version5_removal

ea5c278

fix other ref to v5

ac0576d

Merge branch 'master' into version5_removal

bb0dadd

remove reference to 6.3.3

75f8891

jimczi merged commit f4e9729 into elastic:master Aug 24, 2018

jimczi deleted the version5_removal branch August 24, 2018 07:51

colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unsupported Version.V_5_* #32937

Remove unsupported Version.V_5_* #32937

jimczi commented Aug 17, 2018

jpountz left a comment

jpountz Aug 17, 2018

jimczi Aug 17, 2018

jpountz Aug 17, 2018

jpountz Aug 17, 2018

jpountz Aug 17, 2018

jpountz Aug 17, 2018

jpountz Aug 17, 2018

jpountz Aug 17, 2018

jpountz Aug 17, 2018

jpountz Aug 17, 2018

jpountz Aug 17, 2018

jimczi Aug 17, 2018

jimczi Aug 17, 2018

rjernst Aug 17, 2018

jimczi Aug 17, 2018

rjernst Aug 17, 2018 •

edited

Loading

jimczi Aug 17, 2018

rjernst Aug 17, 2018

jimczi Aug 17, 2018

jimczi Aug 17, 2018

rjernst Aug 17, 2018

jimczi Aug 20, 2018

elasticmachine commented Aug 20, 2018

jpountz left a comment

jimczi commented Aug 23, 2018

s1monw left a comment

s1monw Aug 23, 2018

jimczi Aug 23, 2018

s1monw Aug 23, 2018

jimczi Aug 23, 2018

Remove unsupported Version.V_5_* #32937

Remove unsupported Version.V_5_* #32937

Conversation

jimczi commented Aug 17, 2018

jpountz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rjernst Aug 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

elasticmachine commented Aug 20, 2018

jpountz left a comment

Choose a reason for hiding this comment

jimczi commented Aug 23, 2018

s1monw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rjernst Aug 17, 2018 •

edited

Loading