Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Check for Windows and *nix file paths #31648

Merged
merged 1 commit into from
Jul 2, 2018
Merged

[DOCS] Check for Windows and *nix file paths #31648

merged 1 commit into from
Jul 2, 2018

Conversation

davidkyle
Copy link
Member

Occasional failures of the Docs snippet tests have happened on Windows recently where the error is a ML job cannot be created because one with the same name already exists. ML jobs are supposed to be cleaned up after if the tests is an ML test based on the condition testName.contains("ml/")

See https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-windows-compatibility/1724/console
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-windows-compatibility/1721/console

Looking at the test output:

  1> [2018-06-27T20:58:22,546][INFO ][o.e.s.XDocsClientYamlTestSuiteIT] [test {yaml=en\ml\functions/geo/line_78}]: after test
...
... some other none ML tests
1> [2018-06-27T20:58:24,079][INFO ][o.e.s.XDocsClientYamlTestSuiteIT] [test {yaml=en\ml/aggregations/line_26}]: before test   <-- this test fails because the last ML test was not cleaned up properly

The difference is ml\ vs ml/ and the jobs are not cleaned up after the first test.

XPackRestIT already contains the same check for Windows and *nix path separators.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

droberts195
droberts195 approved these changes Jun 28, 2018
View reviewed changes
Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nik9000
nik9000 approved these changes Jun 28, 2018
View reviewed changes
Copy link
Member

@nik9000 nik9000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. I hadn't seen this before. Looks important to get right though.

@davidkyle davidkyle merged commit 5d94003 into elastic:master Jul 2, 2018
@davidkyle davidkyle deleted the fix-windows-docs-tests branch July 2, 2018 12:10
davidkyle added a commit that referenced this pull request Jul 2, 2018
@davidkyle
[DOCS] Check for Windows and *nix file paths (#31648)
5a66544 
Proper cleanup of the docs snippet tests depends on detecting
what is being tested (ML, Watcher, etc) this is deduced from
the file path and so we must account for Windows and Unix path
separators
davidkyle added a commit that referenced this pull request Jul 3, 2018
@davidkyle
[DOCS] Check for Windows and *nix file paths (#31648)
2fb2bb2 
Proper cleanup of the docs snippet tests depends on detecting
what is being tested (ML, Watcher, etc) this is deduced from
the file path and so we must account for Windows and Unix path
separators
@lcawl lcawl added the >docs General docs changes label Jul 3, 2018
dnhatn added a commit that referenced this pull request Jul 4, 2018
@dnhatn
Merge branch '6.x' into ccr-6.x
151d244 
* 6.x:
  Fix not waiting for Netty ThreadDeathWatcher in IT (#31758) (#31789)
  [Docs] Correct default window_size (#31582)
  S3 fixture should report 404 on unknown bucket (#31782)
  [ML] Limit ML filter items to 10K (#31731)
  Fixture for Minio testing (#31688)
  [ML] Return statistics about forecasts as part of the jobsstats and usage API (#31647)
  [DOCS] Add missing get mappings docs to HLRC (#31765)
  [DOCS] Starting Elasticsearch (#31701)
  Fix coerce validation_method in GeoBoundingBoxQueryBuilder (#31747)
  Painless: Complete Removal of Painless Type (#31699)
  Consolidate watcher setting update registration (#31762)
  [DOCS] Adds empty 6.3.1 release notes page
  ingest: Introduction of a bytes processor (#31733)
  [test] don't run bats tests for suse boxes (#31749)
  Add analyze API to high-level rest client (#31577)
  Implemented XContent serialisation for GetIndexResponse (#31675)
  [DOCS] Typos
  DOC: Add examples to the SQL docs (#31633)
  Add support for AWS session tokens (#30414)
  Watcher: Reenable start/stop yaml tests (#31754)
  JDBC: Fix stackoverflow on getObject and timestamp conversion (#31735)
  Support multiple system store types (#31650)
  Add write*Blob option to replace existing blob (#31729)
  Split CircuitBreaker-related tests (#31659)
  Painless: Add Context Docs (#31190)
  Docs: Remove missing reference
  Migrate scripted metric aggregation scripts to ScriptContext design (#30111)
  Watcher: Fix chain input toXcontent serialization (#31721)
  Remove _all example (#31711)
  rest-high-level: added get cluster settings (#31706)
  Docs: Match the examples in the description (#31710)
  [Docs] Correct typos (#31720)
  Extend allowed characters for grok field names (#21745) (#31653) (#31722)
  [DOCS] Check for Windows and *nix file paths (#31648)
  [ML] Validate ML filter_id (#31535)
  Fix gradle4.8 deprecation warnings (#31654)
  Update numbers to reflect 4-byte UTF-8-encoded characters (#27083)
dnhatn added a commit that referenced this pull request Jul 4, 2018
@dnhatn
Merge branch 'master' into ccr
f736205 
* master:
  [ML] Rate limit established model memory updates (#31768)
  [Docs] Correct default window_size (#31582)
  S3 fixture should report 404 on unknown bucket (#31782)
  Detach Transport from TransportService (#31727)
  [ML] Limit ML filter items to 10K (#31731)
  [ML] Return statistics about forecasts as part of the jobsstats and usage API (#31647)
  Fixture for Minio testing (#31688)
  [DOCS] Add missing get mappings docs to HLRC (#31765)
  [DOCS] Starting Elasticsearch (#31701)
  Painless: Complete Removal of Painless Type (#31699)
  Fix not waiting for Netty ThreadDeathWatcher in IT (#31758)
  Consolidate watcher setting update registration (#31762)
  Build: re-enabled bwc (#31769)
  ingest: Introduction of a bytes processor (#31733)
  Fix coerce validation_method in GeoBoundingBoxQueryBuilder (#31747)
  Add analyze API to high-level rest client (#31577)
  [DOCS] Typos
  DOC: Add examples to the SQL docs (#31633)
  Add support for AWS session tokens (#30414)
  Watcher: Reenable start/stop yaml tests (#31754)
  Implemented XContent serialisation for GetIndexResponse (#31675)
  JDBC: Fix stackoverflow on getObject and timestamp conversion (#31735)
  resolveHasher defaults to NOOP (#31723)
  Account for XContent overhead in in-flight breaker
  Split CircuitBreaker-related tests (#31659)
  Add write*Blob option to replace existing blob (#31729)
  Painless: Add Context Docs (#31190)
  Watcher: Fix chain input toXcontent serialization (#31721)
  Docs: Match the examples in the description (#31710)
  rest-high-level: added get cluster settings (#31706)
  [Docs] Correct typos (#31720)
  Clean up double semicolon code typos (#31687)
  [DOCS] Check for Windows and *nix file paths (#31648)
  [ML] Validate ML filter_id (#31535)
  Revert long lines
  Fix TransportChangePasswordActionTests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droberts195 droberts195 droberts195 approved these changes

@nik9000 nik9000 nik9000 approved these changes

Assignees
No one assigned
Labels
>docs General docs changes v6.3.1 v6.4.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@davidkyle @elasticmachine @nik9000 @droberts195 @colings86 @lcawl