Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update numbers to reflect 4-byte UTF-8-encoded characters #27083

Merged

Conversation

DaveCTurner
Copy link
Contributor

You need 4 bytes for characters outside the BMP, which includes many emoji and a bunch of less-common writing characters too.

Fixes #27060.

You need 4 bytes for characters outside the BMP, which includes many emoji and
a bunch of less-common writing characters too.
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner
Copy link
Contributor Author

@elasticmachine please test this again

@DaveCTurner DaveCTurner merged commit 559fc5a into elastic:master Oct 24, 2017
@DaveCTurner DaveCTurner deleted the issue-27060-more-bytes-in-utf8 branch October 24, 2017 08:50
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Oct 24, 2017
* master:
  Timed runnable should delegate to abstract runnable
  Expose adaptive replica selection stats in /_nodes/stats API
  Remove dangerous `ByteBufStreamInput` methods (elastic#27076)
  Blacklist Gradle 4.2 and above
  Remove duplicated test (elastic#27091)
  Update numbers to reflect 4-byte UTF-8-encoded characters (elastic#27083)
  test: avoid generating duplicate multiple fields (elastic#27080)
  Reduce the default number of cached queries. (elastic#26949)
  removed unused import
  ingest: date processor should not fail if timestamp is specified as json number
@clintongormley clintongormley added the >docs General docs changes label Oct 30, 2017
@DaveCTurner DaveCTurner restored the issue-27060-more-bytes-in-utf8 branch November 22, 2017 15:43
@inqueue
Copy link
Member

inqueue commented Jun 28, 2018

@DaveCTurner The fix for this PR is available at https://www.elastic.co/guide/en/elasticsearch/reference/master/ignore-above.html, but not in 5.x or 6.x documentation. Can it be backported?

@DaveCTurner DaveCTurner deleted the issue-27060-more-bytes-in-utf8 branch July 2, 2018 08:31
DaveCTurner added a commit that referenced this pull request Jul 2, 2018
You need 4 bytes for characters outside the BMP, which includes many emoji and
a bunch of less-common writing characters too.
DaveCTurner added a commit that referenced this pull request Jul 2, 2018
You need 4 bytes for characters outside the BMP, which includes many emoji and
a bunch of less-common writing characters too.
DaveCTurner added a commit that referenced this pull request Jul 2, 2018
You need 4 bytes for characters outside the BMP, which includes many emoji and
a bunch of less-common writing characters too.
DaveCTurner added a commit that referenced this pull request Jul 2, 2018
You need 4 bytes for characters outside the BMP, which includes many emoji and
a bunch of less-common writing characters too.
DaveCTurner added a commit that referenced this pull request Jul 2, 2018
You need 4 bytes for characters outside the BMP, which includes many emoji and
a bunch of less-common writing characters too.
DaveCTurner added a commit that referenced this pull request Jul 2, 2018
You need 4 bytes for characters outside the BMP, which includes many emoji and
a bunch of less-common writing characters too.
@DaveCTurner
Copy link
Contributor Author

Yes, apologies @inqueue, this looks like it should have been backported everywhere. Now done.

dnhatn added a commit that referenced this pull request Jul 4, 2018
* 6.x:
  Fix not waiting for Netty ThreadDeathWatcher in IT (#31758) (#31789)
  [Docs] Correct default window_size (#31582)
  S3 fixture should report 404 on unknown bucket (#31782)
  [ML] Limit ML filter items to 10K (#31731)
  Fixture for Minio testing (#31688)
  [ML] Return statistics about forecasts as part of the jobsstats and usage API (#31647)
  [DOCS] Add missing get mappings docs to HLRC (#31765)
  [DOCS] Starting Elasticsearch (#31701)
  Fix coerce validation_method in GeoBoundingBoxQueryBuilder (#31747)
  Painless: Complete Removal of Painless Type (#31699)
  Consolidate watcher setting update registration (#31762)
  [DOCS] Adds empty 6.3.1 release notes page
  ingest: Introduction of a bytes processor (#31733)
  [test] don't run bats tests for suse boxes (#31749)
  Add analyze API to high-level rest client (#31577)
  Implemented XContent serialisation for GetIndexResponse (#31675)
  [DOCS] Typos
  DOC: Add examples to the SQL docs (#31633)
  Add support for AWS session tokens (#30414)
  Watcher: Reenable start/stop yaml tests (#31754)
  JDBC: Fix stackoverflow on getObject and timestamp conversion (#31735)
  Support multiple system store types (#31650)
  Add write*Blob option to replace existing blob (#31729)
  Split CircuitBreaker-related tests (#31659)
  Painless: Add Context Docs (#31190)
  Docs: Remove missing reference
  Migrate scripted metric aggregation scripts to ScriptContext design (#30111)
  Watcher: Fix chain input toXcontent serialization (#31721)
  Remove _all example (#31711)
  rest-high-level: added get cluster settings (#31706)
  Docs: Match the examples in the description (#31710)
  [Docs] Correct typos (#31720)
  Extend allowed characters for grok field names (#21745) (#31653) (#31722)
  [DOCS] Check for Windows and *nix file paths (#31648)
  [ML] Validate ML filter_id (#31535)
  Fix gradle4.8 deprecation warnings (#31654)
  Update numbers to reflect 4-byte UTF-8-encoded characters (#27083)
@colings86 colings86 removed the v7.0.0 label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants