Fix NPE when GCE region is empty #19176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When GCE region is empty we get back from the API something like:
```
{
"id": "dummy"
}
```
instead of:
```
{
"id": "dummy",
"items":[ ]
}
```
This generates a NPE when we aggregate all the lists into a single one.
Closes elastic#16967.
| @@ -254,4 +254,17 @@ public void testIllegalSettingsMissingZone() { | |||
| assertThat(expected.getMessage(), containsString("one or more gce discovery settings are missing.")); | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * For issue https://github.com/elastic/elasticsearch/issues/16967 | |||
There was a problem hiding this comment.
Can we have a small note on what this test does? link is good but description is better.
Same thing with method name: testNoRegionReturnsEmptyList or something like that
|
Left minor comment, other than that LGTM |
clintongormley
added
:Distributed Coordination/Discovery-Plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GCE region is empty we get back from the API something like:
instead of:
This generates a NPE when we aggregate all the lists into a single one.
Closes #16967.