Add more javadoc and rename test

elastic · Jun 30, 2016 · f9d22b3 · f9d22b3
1 parent 66e3b15
commit f9d22b3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/plugins/discovery-gce/src/test/java/org/elasticsearch/discovery/gce/GceDiscoveryTests.java b/plugins/discovery-gce/src/test/java/org/elasticsearch/discovery/gce/GceDiscoveryTests.java
@@ -256,9 +256,11 @@ public void testIllegalSettingsMissingZone() {
     }
 
     /**
-     * For issue https://github.com/elastic/elasticsearch/issues/16967
+     * For issue https://github.com/elastic/elasticsearch/issues/16967:
+     * When using multiple regions and one of them has no instance at all, this
+     * was producing a NPE as a result.
      */
-    public void testEmptyRegion16967() {
+    public void testNoRegionReturnsEmptyList() {
         Settings nodeSettings = Settings.builder()
             .put(GceComputeService.PROJECT_SETTING.getKey(), projectName)
             .putArray(GceComputeService.ZONE_SETTING.getKey(), "europe-west1-b", "us-central1-a")

diff --git a/...egion16967/zones/europe-west1-b/instances → ...semptylist/zones/europe-west1-b/instances b/...egion16967/zones/europe-west1-b/instances → ...semptylist/zones/europe-west1-b/instances
diff --git a/...region16967/zones/us-central1-a/instances → ...nsemptylist/zones/us-central1-a/instances b/...region16967/zones/us-central1-a/instances → ...nsemptylist/zones/us-central1-a/instances