Change link for HDFS support to plugins docs #15879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clintongormley @costin Could you review this small doc update? |
| @@ -160,7 +160,7 @@ shared file system repository. | |||
| Other repository backends are available in these official plugins: | |||
|
|
|||
| * {plugins}/repository-s3.html[repository-s3] for S3 repository support | |||
| * https://github.com/elasticsearch/elasticsearch-hadoop/tree/master/repository-hdfs[HDFS Plugin] for Hadoop environments | |||
| * {plugins}/repository-s3.html[repository-hdfs] for HDFS repository support in Hadoop environments | |||
There was a problem hiding this comment.
shouldn't be repository-s3.html
There was a problem hiding this comment.
Hahaha! That's why we need reviews even for "stupid" changes! Thanks Clint! :D
|
LGTM. Should be backported to 2.3 as well. |
dadoonet
added a commit
that referenced
this pull request
Jan 11, 2016
Change link for HDFS support to plugins docs
|
@costin Thanks. Merged in master. Regarding 2.x, are you sure the plugin is there? I looked at https://github.com/elastic/elasticsearch/tree/2.x/plugins but can't see it. https://github.com/elastic/elasticsearch/tree/2.x/docs/plugins neither. |
|
Nevermind - 2.x is still 2.2 (I think) hence why it is not there yet. |
|
I don't think you backported yet your plugin to 2.x branch. |
clintongormley
added
:Distributed Coordination/Snapshot/Restore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came to this change when I read #15591
HDFS plugin link has not been updated when we moved HDFS to elasticsearch repository (#15192).