change S3 repository link to elastic/[email protected] #15591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous link went to the outdated repo for ES < 2.0. Two things: * Not sure if it's smart to link current-docs with something like tree/2.0, or if tree/2.x would be better * Not sure if it wouldn't be better to link to the plugin doc page anyway, which would be https://www.elastic.co/guide/en/elasticsearch/plugins/current/cloud-aws.html. Would have to change the other 2 links (HDFS and Azure plugins) too for consistency.
|
ok 1. sorry i messed up the branch name and 2. i did sign the CLA just before submitting the PR, not sure if this check auto-refreshes or something. |
|
Hi @tkaiser Thanks for the PR. I think it makes more sense to link to the docs for each plugin, eg https://www.elastic.co/guide/en/elasticsearch/plugins/current/repository.html Note: These plugins changed names between 2.1 and 2.2 |
|
They changed names in master. |
|
Closing as there has been no feedback, feel free to comment if this was closed erroneously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous link went to the outdated repo for ES < 2.0. Two things: