Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor DataStreamsUpgradeIT::testUpgradeDataStream improvements #119144

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Minor DataStreamsUpgradeIT::testUpgradeDataStream improvements #119144

merged 3 commits into from
Dec 19, 2024

Conversation

masseyke
Copy link
Member

This is a collection of a few minor enhancements to DataStreamsUpgradeIT::testUpgradeDataStream:

  • It makes the number of rollovers (and therefore backing indices) random from 0-5
  • It adds a few additional assertions about the status response
  • It fixes a bug where the test would fail if it were running during an upgrade between minor versions (e.g. 9.0->9.1)

@masseyke masseyke added >test Issues or PRs that are addressing/adding tests :Data Management/Data streams Data streams and their lifecycles auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.0 labels Dec 19, 2024
@masseyke masseyke changed the title Data streams upgrade it improvements Minor DataStreamsUpgradeIT::testUpgradeDataStream improvements Dec 19, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Dec 19, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@masseyke masseyke merged commit 04dbe3c into elastic:main Dec 19, 2024
16 checks passed
@masseyke masseyke deleted the DataStreamsUpgradeIT-improvements branch December 19, 2024 21:26
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 119144

masseyke added a commit to masseyke/elasticsearch that referenced this pull request Dec 19, 2024
@masseyke
Minor DataStreamsUpgradeIT::testUpgradeDataStream improvements (elast…
00cc9e2 
…ic#119144)
elasticsearchmachine pushed a commit that referenced this pull request Dec 20, 2024
@masseyke
Minor DataStreamsUpgradeIT::testUpgradeDataStream improvements (#119144…
fdc401e 
…) (#119169)
navarone-feekery pushed a commit to navarone-feekery/elasticsearch that referenced this pull request Dec 26, 2024
@masseyke @navarone-feekery
Minor DataStreamsUpgradeIT::testUpgradeDataStream improvements (elast…
9787f4e 
…ic#119144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkertimmins parkertimmins parkertimmins approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masseyke @elasticsearchmachine @parkertimmins