Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] ESQL: Evaluator check function tests (#117715) #118316

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

ivancea
Copy link
Contributor

@ivancea ivancea commented Dec 10, 2024

Backports the following commits to 8.x:

Multiple scalar function tests were being ignored if they had any non-representable child (counters, durations, periods...).

Here, I'm making that "can have an evaluator" a bit more explicit in every test, as many of the ignored tests cases were actually "working".
@ivancea ivancea added :Analytics/ES|QL AKA ESQL >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Dec 10, 2024
@elasticsearchmachine elasticsearchmachine merged commit 5c9cd6c into elastic:8.x Dec 10, 2024
15 checks passed
@ivancea ivancea deleted the backport/8.x/pr-117715 branch December 10, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants