ESQL: Evaluator check function tests #117715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/TestCaseSupplier.java
ivancea
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/TestCaseSupplier.java: Evaluated as low risk
Comments skipped due to low confidence (1)
x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/convert/ToDoubleTests.java:127
- [nitpick] The evaluator name 'Int' is less descriptive than 'Integer'. It should be renamed back to 'Integer'.
evaluatorName.apply("Int")
nik9000
approved these changes
Dec 4, 2024
ivancea
force-pushed
the
evaluator-check-function-tests
branch
from
e6f527a to
d30cbac
Compare
# Conflicts: # x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/predicate/operator/arithmetic/SubTests.java
💚 Backport successful
|
ivancea
added a commit
to ivancea/elasticsearch
that referenced
this pull request
Dec 10, 2024
Multiple scalar function tests were being ignored if they had any non-representable child (counters, durations, periods...). Here, I'm making that "can have an evaluator" a bit more explicit in every test, as many of the ignored tests cases were actually "working".
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 10, 2024
Multiple scalar function tests were being ignored if they had any non-representable child (counters, durations, periods...). Here, I'm making that "can have an evaluator" a bit more explicit in every test, as many of the ignored tests cases were actually "working".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple scalar function tests were being ignored if they had any non-representable child (counters, durations, periods...).
Here, I'm making that "can have an evaluator" a bit more explicit in every test, as many of the ignored tests cases were actually "working".
Now, either the testcase is explicitly marked with->Now.withoutEvaluator(), or the return type is non-representable (I kept this logic as to avoid adding.withoutEvaluator()to more tests, but could be changed too; only other 2-4 tests would need changes right now)..withoutEvaluator()must be explicit