Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Remove regex #113210

Merged
merged 4 commits into from
Sep 23, 2024
Merged

[ML] Remove regex #113210

merged 4 commits into from
Sep 23, 2024

Conversation

prwhelan
Copy link
Member

Regex is having trouble parsing some of the larger UTF8 characters, so instead we are just going to use our non-regex parser.

Fix #113179
Fix #113148

Regex is having trouble parsing some of the larger UTF8 characters, so
instead we are just going to use our non-regex parser.

Fix elastic#113179
Fix elastic#113148
@prwhelan prwhelan added >test Issues or PRs that are addressing/adding tests :ml Machine learning Team:ML Meta label for the ML team auto-backport-and-merge v8.16.0 v9.0.0 labels Sep 19, 2024
@prwhelan prwhelan marked this pull request as ready for review September 19, 2024 19:23
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@prwhelan
Copy link
Member Author

@elasticmachine update branch

@prwhelan
Copy link
Member Author

@elasticmachine update branch

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prwhelan
Copy link
Member Author

@elasticmachine update branch

@prwhelan prwhelan merged commit 09fc9dd into elastic:main Sep 23, 2024
15 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

prwhelan added a commit to prwhelan/elasticsearch that referenced this pull request Sep 23, 2024
Regex is having trouble parsing some of the larger UTF8 characters, so
instead we are just going to use our non-regex parser.

Fix elastic#113179
Fix elastic#113148

Co-authored-by: Elastic Machine <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Sep 23, 2024
Regex is having trouble parsing some of the larger UTF8 characters, so
instead we are just going to use our non-regex parser.

Fix #113179
Fix #113148

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.16.0 v9.0.0
Projects
None yet
4 participants