Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] ServerSentEventsRestActionListenerTests testErrorMidStream failing #113179

Closed
elasticsearchmachine opened this issue Sep 19, 2024 · 2 comments · Fixed by #113210
Closed

[CI] ServerSentEventsRestActionListenerTests testErrorMidStream failing #113179

elasticsearchmachine opened this issue Sep 19, 2024 · 2 comments · Fixed by #113210
Assignees
@prwhelan
Labels
:ml Machine learning needs:risk Requires assignment of a risk label (low, medium, blocker) Team:ML Meta label for the ML team >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Sep 19, 2024 •
edited
Loading

Build Scans:

Reproduction Line:

./gradlew ":x-pack:plugin:inference:internalClusterTest" --tests "org.elasticsearch.xpack.inference.rest.ServerSentEventsRestActionListenerTests.testErrorMidStream" -Dtests.seed=22EF332DA20071CE -Dtests.locale=om-ET -Dtests.timezone=Australia/West -Druntime.java=22

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: No exceptions should be thrown.
Expected: null
     but: was <java.io.IOException: Line does not match expected JSON message or DONE message. Line: event: message
data: {"delta":"fv̍샏
䃼窼\uD948\uDE45ǝЭ\u0014y"}>

Issue Reasons:

  • [main] 2 consecutive failures in test testErrorMidStream
  • [main] 3 failures in test testErrorMidStream (2.4% fail rate in 123 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :ml Machine learning >test-failure Triaged test failures from CI labels Sep 19, 2024
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 2 failures in test testErrorMidStream (1.6% fail rate in 123 executions)

Build Scans:

elasticsearchmachine added a commit that referenced this issue Sep 19, 2024
@elasticsearchmachine
Mute org.elasticsearch.xpack.inference.rest.ServerSentEventsRestActio…
0028159 
…nListenerTests testErrorMidStream #113179
@elasticsearchmachine elasticsearchmachine added Team:ML Meta label for the ML team needs:risk Requires assignment of a risk label (low, medium, blocker) labels Sep 19, 2024
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/ml-core (Team:ML)

@prwhelan prwhelan self-assigned this Sep 19, 2024
prwhelan added a commit to prwhelan/elasticsearch that referenced this issue Sep 19, 2024
@prwhelan
[ML] Remove regex
e591d25 
Regex is having trouble parsing some of the larger UTF8 characters, so
instead we are just going to use our non-regex parser.

Fix elastic#113179
Fix elastic#113148
@prwhelan prwhelan mentioned this issue Sep 19, 2024
Merged
prwhelan added a commit that referenced this issue Sep 23, 2024
@prwhelan @elasticmachine
[ML] Remove regex (#113210)
09fc9dd 
Regex is having trouble parsing some of the larger UTF8 characters, so
instead we are just going to use our non-regex parser.

Fix #113179
Fix #113148

Co-authored-by: Elastic Machine <[email protected]>
prwhelan added a commit to prwhelan/elasticsearch that referenced this issue Sep 23, 2024
@prwhelan @elasticmachine
[ML] Remove regex (elastic#113210)
c16f372 
Regex is having trouble parsing some of the larger UTF8 characters, so
instead we are just going to use our non-regex parser.

Fix elastic#113179
Fix elastic#113148

Co-authored-by: Elastic Machine <[email protected]>
elasticsearchmachine pushed a commit that referenced this issue Sep 23, 2024
@prwhelan @elasticmachine
[ML] Remove regex (#113210) (#113380)
ce25f45 
Regex is having trouble parsing some of the larger UTF8 characters, so
instead we are just going to use our non-regex parser.

Fix #113179
Fix #113148

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prwhelan prwhelan

Labels
:ml Machine learning needs:risk Requires assignment of a risk label (low, medium, blocker) Team:ML Meta label for the ML team >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML] Remove regex prwhelan/elasticsearch
2 participants
@prwhelan @elasticsearchmachine