Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Convert final examples from JSON to YAML #3692

Merged
merged 2 commits into from
Feb 3, 2025
Merged

[DOCS] Convert final examples from JSON to YAML #3692

merged 2 commits into from
Feb 3, 2025

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Feb 3, 2025

This PR converts more examples from JSON to YAML to address linting errors related to invalid fields in those files.
It also comments out some of those lingering fields from existing example files.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
bulk 🟢 445/445 463/463
ccr.delete_auto_follow_pattern Missing test Missing test
ccr.follow_info Missing test Missing test
ingest.put_pipeline 🟢 60/60 60/60
ml.close_job 🟢 64/64 63/63
ml.delete_calendar_event 🟢 4/4 4/4
ml.estimate_model_memory 🟢 16/16 16/16

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl changed the title [DOCS] Convert more examples from JSON to YAML [DOCS] Convert final examples from JSON to YAML Feb 3, 2025
@lcawl lcawl requested a review from a team February 3, 2025 22:09
@lcawl lcawl marked this pull request as ready for review February 3, 2025 22:09
@lcawl lcawl requested review from a team as code owners February 3, 2025 22:09
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
async_search.delete 🟢 4/4 4/4
async_search.get 🟢 6/6 6/6
async_search.status 🟢 3/3 3/3
async_search.submit 🟢 7/7 7/7
bulk 🟢 445/445 463/463
ccr.delete_auto_follow_pattern Missing test Missing test
ccr.follow_info Missing test Missing test
ccr.follow Missing test Missing test
cluster.health 🟢 159/159 159/159
ingest.put_pipeline 🟢 60/60 60/60
ml.close_job 🟢 64/64 63/63
ml.delete_calendar_event 🟢 4/4 4/4
ml.estimate_model_memory 🟢 16/16 16/16

You can validate these APIs yourself by using the make validate target.

Copy link

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐙

@lcawl lcawl merged commit 4a30d3a into main Feb 3, 2025
8 checks passed
@lcawl lcawl deleted the examples-4 branch February 3, 2025 22:17
github-actions bot pushed a commit that referenced this pull request Feb 3, 2025
github-actions bot pushed a commit that referenced this pull request Feb 3, 2025
lcawl added a commit that referenced this pull request Feb 3, 2025
(cherry picked from commit 4a30d3a)

Co-authored-by: Lisa Cawley <[email protected]>
lcawl added a commit that referenced this pull request Feb 4, 2025
(cherry picked from commit 4a30d3a)

Co-authored-by: Lisa Cawley <[email protected]>
pquentin pushed a commit that referenced this pull request Feb 6, 2025
* [DOCS] Fix overlay for resolve cluster (#3670)

* Update specification output

* uppercase enum source mode (#3676)

* [DOCS] Add overlays for CCR API examples (#3672)

* Update inference.update.json with the correct verb (#3688)

* Update specification output

* [DOCS] Convert final examples from JSON to YAML (#3692)

* Update specification output

* Correcting the response format for ingest simulate (#3640)

* Correcting the response format for ingest simulate

* code review feedback

* moving error to the correct place, and adding ignored_fields

* Update specification/simulate/ingest/SimulateIngestResponse.ts

Co-authored-by: Laura Trotta <[email protected]>

---------

Co-authored-by: Laura Trotta <[email protected]>

* Update specification output

* Add text_embedding_bits to inference result output (#3698)

* Update specification output

* Improve `Analyzer` definitions and fix various classes (#3215)

* Update specification output

---------

Co-authored-by: Lisa Cawley <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Laura Trotta <[email protected]>
Co-authored-by: David Kyle <[email protected]>
Co-authored-by: Keith Massey <[email protected]>
Co-authored-by: Ying Mao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants