-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Analyzer
definitions and fix various classes
#3215
base: main
Are you sure you want to change the base?
Conversation
0bd910e
to
9765060
Compare
the |
definitely not easy to check the code here, because it relies on Lucene classes a lot, but I think everything else looks good! |
Thanks a lot for checking @l-trotta 🙂 Do you know which version of the server deprecated the |
@flobernd 7.14.0! elastic/elasticsearch#74073 |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Analyzer
definitionsAnalyzer
definitions and fix various classes
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
e0c41c1
to
cc404ce
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Some analyzers had properties incorrectly marked as "required". As well added documentation for all documented fields.
This PR as well fixes different classes in various namespaces. These discrepancies have been found while working on the request converter. Thanks @l-trotta for double-checking my changes on base of the server code!