Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] do not output error message for connections closed due to timeout #241

Merged
merged 5 commits into from
Nov 14, 2024
Merged

[BUG] do not output error message for connections closed due to timeout #241

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f6a0c7b
do not output error log for connection closed
khushijain21 Oct 23, 2024
bd5ba8d
add test to reproduce this error
khushijain21 Nov 12, 2024
b9b0403
linting issue
khushijain21 Nov 12, 2024
c5b5fcb
Merge branch 'main' into debugmsg
khushijain21 Nov 12, 2024
926e0a6
nolint comments
khushijain21 Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion transport/logging.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,12 @@ func LoggingDialer(d Dialer, logger *logp.Logger) Dialer {
func (l *loggingConn) Read(b []byte) (int, error) {
n, err := l.Conn.Read(b)
if err != nil && !errors.Is(err, io.EOF) {
l.logger.Debugf("Error reading from connection: %v", err)
// Check for a closed network connection error
if errors.Is(err, net.ErrClosed) {
l.logger.Debugf("Connection is closed: %v", err)
VihasMakwana marked this conversation as resolved.
Show resolved Hide resolved
} else {
l.logger.Debugf("Error reading from connection: %v", err)
}
}
return n, err
}
Expand Down
Loading