[BUG] do not output error message for connections closed due to timeout #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushijain21
requested review from
faec and
VihasMakwana
and removed request for
a team
VihasMakwana
requested changes
Oct 23, 2024
VihasMakwana
approved these changes
Oct 23, 2024
khushijain21
changed the title
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
rdner
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Blocking this PR until we find a better solution. See elastic/beats#40824 (comment)
khushijain21
force-pushed
the
debugmsg
branch
from
42cede5 to
8e14431
Compare
khushijain21
force-pushed
the
debugmsg
branch
from
8e14431 to
bd5ba8d
Compare
💚 Build Succeeded
History
|
rdner
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
After some investigation with @khushijain21 we didn't find a better solution other than skipping the log entries for the closed connection error.
This error is still returned and should be handled and logged by the consumer of loggingConn type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes elastic/beats#40824
Why is it important?
Avoid polluting log with
use of closed connectionerrors due toidleConnectiontimeoutChecklist