Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] Fix the actual cloud.provider example. (#348) #361

Merged
merged 2 commits into from
Mar 5, 2019
Merged

[1.0] Fix the actual cloud.provider example. (#348) #361

merged 2 commits into from
Mar 5, 2019

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Mar 5, 2019

Backports the following commits to 1.0:

@ruflin ruflin added the backport label Mar 5, 2019
webmat
webmat reviewed Mar 5, 2019
View reviewed changes
schema.json Outdated Show resolved Hide resolved
@webmat
Copy link
Contributor

webmat commented Mar 5, 2019

Make sure to delete schema.json here

@ruflin ruflin force-pushed the backport/1.0/pr-348 branch from ae3fc46 to 37f7dd9 Compare March 5, 2019 19:22
@ruflin
Copy link
Contributor Author

ruflin commented Mar 5, 2019

@webmat Rebased.

webmat
webmat approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's merge right away. It was green before fixing the conflict

@ruflin ruflin merged commit e4f1941 into elastic:1.0 Mar 5, 2019
@ruflin ruflin deleted the backport/1.0/pr-348 branch March 5, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmat webmat webmat approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruflin @webmat