Fix the actual cloud.provider example. #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
reviewed
Feb 28, 2019
| @@ -222,7 +222,7 @@ | |||
| fields: | |||
| - name: provider | |||
| level: extended | |||
| example: ec2 | |||
There was a problem hiding this comment.
The implementation in Beats populates this with ec2. It would be helpful to have a list of names in ECS to use for popular providers. Ironically one of the providers is using ecs. https://github.com/elastic/beats/blob/master/libbeat/docs/processors-using.asciidoc#add-cloud-metadata
There was a problem hiding this comment.
I think the document example is better using "aws" but there could be a case for using service.name in cloud-provider relevant events to capture the service such as "ec2." Agree we could expand the list of examples to eventually become a set of defined names.
There was a problem hiding this comment.
Agreed on the enums. However they will come after 1.0 :-)
PR elastic#330 only fixed the text in the description :-)
webmat
force-pushed
the
fix-actual-cloud-example
branch
from
5550f71 to
91f921f
Compare
ruflin
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #330 only fixed the text in the description :-)