Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Deprecation Notice relating to RFC 0017: Remove log.original #1469

Merged
merged 12 commits into from
Jun 28, 2021
Merged

Implement Deprecation Notice relating to RFC 0017: Remove log.original #1469

merged 12 commits into from
Jun 28, 2021

Conversation

djptek
Copy link
Contributor

@djptek djptek commented Jun 23, 2021 •
edited
Loading

  • Have you signed the contributor license agreement? Y
  • Have you followed the contributor guidelines? Y
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? Y
  • If submitting code/script changes, have you verified all tests pass locally using make test? Y
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? Y
  • Is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed. Y
  • Have you added an entry to the CHANGELOG.next.md? Y

Implements Deprecation Notice relating to RFC 0017: Remove log.original

@djptek djptek changed the title Implement rfc 0017 Implement RFC 0017 Jun 23, 2021
@djptek djptek changed the title Implement RFC 0017 Implement Deprecation Notice relating to RFC 0017: Remove log.original Jun 23, 2021
ebeahan
ebeahan reviewed Jun 23, 2021
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My browser was autocorrecting to superseded, but superceded looks like it's a common variant .

I don't feel strongly though about which variant we use. 😄

schemas/log.yml Outdated Show resolved Hide resolved
schemas/log.yml Outdated Show resolved Hide resolved
schemas/log.yml Outdated Show resolved Hide resolved
CHANGELOG.next.md Outdated Show resolved Hide resolved
djptek and others added 6 commits June 23, 2021 19:13
@djptek @ebeahan
Update schemas/log.yml
8c23864 
I'll defer to Merriam Webster, thanks for spotting

Co-authored-by: Eric Beahan <[email protected]>
@djptek @ebeahan
Update schemas/log.yml
fbf8b95 
Co-authored-by: Eric Beahan <[email protected]>
@djptek @ebeahan
Update CHANGELOG.next.md
c9a9f20 
I'll defer to Merriam Webster, thanks for spotting

Co-authored-by: Eric Beahan <[email protected]>
@djptek @ebeahan
Update schemas/log.yml
32d3371 
Co-authored-by: Eric Beahan <[email protected]>
@djptek
Merge branch 'master' into implement_rfc_0017
b6cce2f
make check
3b9968d
@djptek djptek requested a review from ebeahan June 23, 2021 17:36
ebeahan
ebeahan approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djptek djptek merged commit 9f6d0ef into elastic:master Jun 28, 2021
ebeahan pushed a commit to ebeahan/ecs that referenced this pull request Jun 29, 2021
@djptek @ebeahan
Implement Deprecation Notice relating to RFC 0017: Remove log.original (
12a894e 
elastic#1469)

* apply Deprecation of log.original

Co-authored-by: Eric Beahan <[email protected]>
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
@ebeahan ebeahan mentioned this pull request Jun 29, 2021
Merged
ebeahan added a commit that referenced this pull request Jun 29, 2021
@ebeahan @djptek
Implement Deprecation Notice relating to RFC 0017: Remove log.original (
4488788 
#1469) (#1486)

* apply Deprecation of log.original

Co-authored-by: Eric Beahan <[email protected]>
Co-authored-by: Dominic Page <[email protected]>
@leehinman leehinman mentioned this pull request Jul 19, 2021
Closed
@djptek djptek mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebeahan ebeahan ebeahan approved these changes

Assignees
No one assigned
Labels
1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djptek @ebeahan