Skip to content

Commit

Permalink
Implement Deprecation Notice relating to RFC 0017: Remove log.original (
Browse files Browse the repository at this point in the history
elastic#1469)

* apply Deprecation of log.original

Co-authored-by: Eric Beahan <[email protected]>
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
  • Loading branch information
djptek authored and ebeahan committed Jun 29, 2021
1 parent 5c4b688 commit 12a894e
Show file tree
Hide file tree
Showing 14 changed files with 98 additions and 46 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.next.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ Thanks, you're awesome :-) -->
#### Deprecated

* Note deprecation of the `host.user.*` field reuse. #1422
* Note deprecation of `log.original` superseded by `event.original` #1469

### Tooling and Artifact Changes

Expand Down
8 changes: 5 additions & 3 deletions code/go/ecs/event.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions code/go/ecs/log.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions docs/field-details.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -2777,9 +2777,9 @@ example: `apache`
[[field-event-original]]
<<field-event-original, event.original>>

| Raw text message of entire event. Used to demonstrate log integrity.
| Raw text message of entire event. Used to demonstrate log integrity or where the full log message (before splitting it up in multiple parts) may be required, e.g. for reindex.

This field is not indexed and doc_values are disabled. It cannot be searched, but it can be retrieved from `_source`. If users wish to override this and index this field, consider using the wildcard data type.
This field is not indexed and doc_values are disabled. It cannot be searched, but it can be retrieved from `_source`. If users wish to override this and index this field, please see `Field data types` in the `Elasticsearch Reference`.

type: keyword

Expand Down Expand Up @@ -4684,7 +4684,9 @@ example: `init`
[[field-log-original]]
<<field-log-original, log.original>>

| This is the original log message and contains the full log message before splitting it up in multiple parts.
| Deprecated for removal in next major version release. This field is superseded by `event.original`.

This is the original log message and contains the full log message before splitting it up in multiple parts.

In contrast to the `message` field which can contain an extracted part of the log message, this field contains the original, full log message. It can have already some modifications applied like encoding or new lines removed to clean up the log message.

Expand Down
19 changes: 13 additions & 6 deletions experimental/generated/beats/fields.ecs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1926,11 +1926,13 @@
level: core
type: keyword
ignore_above: 1024
description: 'Raw text message of entire event. Used to demonstrate log integrity.
description: 'Raw text message of entire event. Used to demonstrate log integrity or
where the full log message (before splitting it up in multiple parts) may
be required, e.g. for reindex.
This field is not indexed and doc_values are disabled. It cannot be searched,
but it can be retrieved from `_source`. If users wish to override this and
index this field, consider using the wildcard data type.'
index this field, please see `Field data types` in the `Elasticsearch Reference`.'
example: Sep 19 08:26:10 host CEF:0&#124;Security&#124; threatmanager&#124;1.0&#124;100&#124;
worm successfully stopped&#124;10&#124;src=10.0.0.1 dst=2.1.2.2spt=1232
index: false
Expand Down Expand Up @@ -3625,8 +3627,11 @@
level: core
type: keyword
ignore_above: 1024
description: 'This is the original log message and contains the full log message
before splitting it up in multiple parts.
description: 'Deprecated for removal in next major version release. This field
is superseded by `event.original`.
This is the original log message and contains the full log message before
splitting it up in multiple parts.
In contrast to the `message` field which can contain an extracted part of
the log message, this field contains the original, full log message. It can
Expand Down Expand Up @@ -8446,11 +8451,13 @@
level: core
type: keyword
ignore_above: 1024
description: 'Raw text message of entire event. Used to demonstrate log integrity.
description: 'Raw text message of entire event. Used to demonstrate log integrity or
where the full log message (before splitting it up in multiple parts) may
be required, e.g. for reindex.
This field is not indexed and doc_values are disabled. It cannot be searched,
but it can be retrieved from `_source`. If users wish to override this and
index this field, consider using the wildcard data type.'
index this field, please see `Field data types` in the `Elasticsearch Reference`.'
example: Sep 19 08:26:10 host CEF:0&#124;Security&#124; threatmanager&#124;1.0&#124;100&#124;
worm successfully stopped&#124;10&#124;src=10.0.0.1 dst=2.1.2.2spt=1232
index: false
Expand Down
2 changes: 1 addition & 1 deletion experimental/generated/csv/fields.csv
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ ECS_Version,Indexed,Field_Set,Field,Type,Level,Normalization,Example,Description
1.11.0-dev+exp,true,log,log.origin.file.line,integer,extended,,42,The line number of the file which originated the log event.
1.11.0-dev+exp,true,log,log.origin.file.name,keyword,extended,,Bootstrap.java,The code file which originated the log event.
1.11.0-dev+exp,true,log,log.origin.function,keyword,extended,,init,The function which originated the log event.
1.11.0-dev+exp,false,log,log.original,keyword,core,,Sep 19 08:26:10 localhost My log,"Original log message with light interpretation only (encoding, newlines)."
1.11.0-dev+exp,false,log,log.original,keyword,core,,Sep 19 08:26:10 localhost My log,"Deprecated original log message with light interpretation only (encoding, newlines)."
1.11.0-dev+exp,true,log,log.syslog,object,extended,,,Syslog metadata
1.11.0-dev+exp,true,log,log.syslog.facility.code,long,extended,,23,Syslog numeric facility of the event.
1.11.0-dev+exp,true,log,log.syslog.facility.name,keyword,extended,,local7,Syslog text-based facility of the event.
Expand Down
22 changes: 15 additions & 7 deletions experimental/generated/ecs/ecs_flat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2644,11 +2644,13 @@ event.module:
type: keyword
event.original:
dashed_name: event-original
description: 'Raw text message of entire event. Used to demonstrate log integrity.
description: 'Raw text message of entire event. Used to demonstrate log integrity or
where the full log message (before splitting it up in multiple parts) may be
required, e.g. for reindex.

This field is not indexed and doc_values are disabled. It cannot be searched,
but it can be retrieved from `_source`. If users wish to override this and index
this field, consider using the wildcard data type.'
this field, please see `Field data types` in the `Elasticsearch Reference`.'
doc_values: false
example: Sep 19 08:26:10 host CEF:0&#124;Security&#124; threatmanager&#124;1.0&#124;100&#124;
worm successfully stopped&#124;10&#124;src=10.0.0.1 dst=2.1.2.2spt=1232
Expand Down Expand Up @@ -5329,8 +5331,11 @@ log.origin.function:
type: keyword
log.original:
dashed_name: log-original
description: 'This is the original log message and contains the full log message
before splitting it up in multiple parts.
description: 'Deprecated for removal in next major version release. This field is
superseded by `event.original`.

This is the original log message and contains the full log message before splitting
it up in multiple parts.

In contrast to the `message` field which can contain an extracted part of the
log message, this field contains the original, full log message. It can have already
Expand All @@ -5347,7 +5352,8 @@ log.original:
level: core
name: original
normalize: []
short: Original log message with light interpretation only (encoding, newlines).
short: Deprecated original log message with light interpretation only (encoding,
newlines).
type: keyword
log.syslog:
dashed_name: log-syslog
Expand Down Expand Up @@ -12912,11 +12918,13 @@ threat.enrichments.event.module:
type: keyword
threat.enrichments.event.original:
dashed_name: threat-enrichments-event-original
description: 'Raw text message of entire event. Used to demonstrate log integrity.
description: 'Raw text message of entire event. Used to demonstrate log integrity or
where the full log message (before splitting it up in multiple parts) may be
required, e.g. for reindex.

This field is not indexed and doc_values are disabled. It cannot be searched,
but it can be retrieved from `_source`. If users wish to override this and index
this field, consider using the wildcard data type.'
this field, please see `Field data types` in the `Elasticsearch Reference`.'
doc_values: false
example: Sep 19 08:26:10 host CEF:0&#124;Security&#124; threatmanager&#124;1.0&#124;100&#124;
worm successfully stopped&#124;10&#124;src=10.0.0.1 dst=2.1.2.2spt=1232
Expand Down
22 changes: 15 additions & 7 deletions experimental/generated/ecs/ecs_nested.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3421,11 +3421,13 @@ event:
type: keyword
event.original:
dashed_name: event-original
description: 'Raw text message of entire event. Used to demonstrate log integrity.
description: 'Raw text message of entire event. Used to demonstrate log integrity or
where the full log message (before splitting it up in multiple parts) may
be required, e.g. for reindex.

This field is not indexed and doc_values are disabled. It cannot be searched,
but it can be retrieved from `_source`. If users wish to override this and
index this field, consider using the wildcard data type.'
index this field, please see `Field data types` in the `Elasticsearch Reference`.'
doc_values: false
example: Sep 19 08:26:10 host CEF:0&#124;Security&#124; threatmanager&#124;1.0&#124;100&#124;
worm successfully stopped&#124;10&#124;src=10.0.0.1 dst=2.1.2.2spt=1232
Expand Down Expand Up @@ -6533,8 +6535,11 @@ log:
type: keyword
log.original:
dashed_name: log-original
description: 'This is the original log message and contains the full log message
before splitting it up in multiple parts.
description: 'Deprecated for removal in next major version release. This field
is superseded by `event.original`.

This is the original log message and contains the full log message before
splitting it up in multiple parts.

In contrast to the `message` field which can contain an extracted part of
the log message, this field contains the original, full log message. It can
Expand All @@ -6551,7 +6556,8 @@ log:
level: core
name: original
normalize: []
short: Original log message with light interpretation only (encoding, newlines).
short: Deprecated original log message with light interpretation only (encoding,
newlines).
type: keyword
log.syslog:
dashed_name: log-syslog
Expand Down Expand Up @@ -14962,11 +14968,13 @@ threat:
type: keyword
threat.enrichments.event.original:
dashed_name: threat-enrichments-event-original
description: 'Raw text message of entire event. Used to demonstrate log integrity.
description: 'Raw text message of entire event. Used to demonstrate log integrity or
where the full log message (before splitting it up in multiple parts) may
be required, e.g. for reindex.

This field is not indexed and doc_values are disabled. It cannot be searched,
but it can be retrieved from `_source`. If users wish to override this and
index this field, consider using the wildcard data type.'
index this field, please see `Field data types` in the `Elasticsearch Reference`.'
doc_values: false
example: Sep 19 08:26:10 host CEF:0&#124;Security&#124; threatmanager&#124;1.0&#124;100&#124;
worm successfully stopped&#124;10&#124;src=10.0.0.1 dst=2.1.2.2spt=1232
Expand Down
13 changes: 9 additions & 4 deletions generated/beats/fields.ecs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1738,11 +1738,13 @@
level: core
type: keyword
ignore_above: 1024
description: 'Raw text message of entire event. Used to demonstrate log integrity.
description: 'Raw text message of entire event. Used to demonstrate log integrity or
where the full log message (before splitting it up in multiple parts) may
be required, e.g. for reindex.

This field is not indexed and doc_values are disabled. It cannot be searched,
but it can be retrieved from `_source`. If users wish to override this and
index this field, consider using the wildcard data type.'
index this field, please see `Field data types` in the `Elasticsearch Reference`.'
example: Sep 19 08:26:10 host CEF:0&#124;Security&#124; threatmanager&#124;1.0&#124;100&#124;
worm successfully stopped&#124;10&#124;src=10.0.0.1 dst=2.1.2.2spt=1232
index: false
Expand Down Expand Up @@ -3246,8 +3248,11 @@
level: core
type: keyword
ignore_above: 1024
description: 'This is the original log message and contains the full log message
before splitting it up in multiple parts.
description: 'Deprecated for removal in next major version release. This field
is superseded by `event.original`.

This is the original log message and contains the full log message before
splitting it up in multiple parts.

In contrast to the `message` field which can contain an extracted part of
the log message, this field contains the original, full log message. It can
Expand Down
2 changes: 1 addition & 1 deletion generated/csv/fields.csv
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ ECS_Version,Indexed,Field_Set,Field,Type,Level,Normalization,Example,Description
1.11.0-dev,true,log,log.origin.file.line,integer,extended,,42,The line number of the file which originated the log event.
1.11.0-dev,true,log,log.origin.file.name,keyword,extended,,Bootstrap.java,The code file which originated the log event.
1.11.0-dev,true,log,log.origin.function,keyword,extended,,init,The function which originated the log event.
1.11.0-dev,false,log,log.original,keyword,core,,Sep 19 08:26:10 localhost My log,"Original log message with light interpretation only (encoding, newlines)."
1.11.0-dev,false,log,log.original,keyword,core,,Sep 19 08:26:10 localhost My log,"Deprecated original log message with light interpretation only (encoding, newlines)."
1.11.0-dev,true,log,log.syslog,object,extended,,,Syslog metadata
1.11.0-dev,true,log,log.syslog.facility.code,long,extended,,23,Syslog numeric facility of the event.
1.11.0-dev,true,log,log.syslog.facility.name,keyword,extended,,local7,Syslog text-based facility of the event.
Expand Down
16 changes: 11 additions & 5 deletions generated/ecs/ecs_flat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2295,11 +2295,13 @@ event.module:
type: keyword
event.original:
dashed_name: event-original
description: 'Raw text message of entire event. Used to demonstrate log integrity.
description: 'Raw text message of entire event. Used to demonstrate log integrity or
where the full log message (before splitting it up in multiple parts) may be
required, e.g. for reindex.

This field is not indexed and doc_values are disabled. It cannot be searched,
but it can be retrieved from `_source`. If users wish to override this and index
this field, consider using the wildcard data type.'
this field, please see `Field data types` in the `Elasticsearch Reference`.'
doc_values: false
example: Sep 19 08:26:10 host CEF:0&#124;Security&#124; threatmanager&#124;1.0&#124;100&#124;
worm successfully stopped&#124;10&#124;src=10.0.0.1 dst=2.1.2.2spt=1232
Expand Down Expand Up @@ -4627,8 +4629,11 @@ log.origin.function:
type: keyword
log.original:
dashed_name: log-original
description: 'This is the original log message and contains the full log message
before splitting it up in multiple parts.
description: 'Deprecated for removal in next major version release. This field is
superseded by `event.original`.

This is the original log message and contains the full log message before splitting
it up in multiple parts.

In contrast to the `message` field which can contain an extracted part of the
log message, this field contains the original, full log message. It can have already
Expand All @@ -4645,7 +4650,8 @@ log.original:
level: core
name: original
normalize: []
short: Original log message with light interpretation only (encoding, newlines).
short: Deprecated original log message with light interpretation only (encoding,
newlines).
type: keyword
log.syslog:
dashed_name: log-syslog
Expand Down
16 changes: 11 additions & 5 deletions generated/ecs/ecs_nested.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3069,11 +3069,13 @@ event:
type: keyword
event.original:
dashed_name: event-original
description: 'Raw text message of entire event. Used to demonstrate log integrity.
description: 'Raw text message of entire event. Used to demonstrate log integrity or
where the full log message (before splitting it up in multiple parts) may
be required, e.g. for reindex.

This field is not indexed and doc_values are disabled. It cannot be searched,
but it can be retrieved from `_source`. If users wish to override this and
index this field, consider using the wildcard data type.'
index this field, please see `Field data types` in the `Elasticsearch Reference`.'
doc_values: false
example: Sep 19 08:26:10 host CEF:0&#124;Security&#124; threatmanager&#124;1.0&#124;100&#124;
worm successfully stopped&#124;10&#124;src=10.0.0.1 dst=2.1.2.2spt=1232
Expand Down Expand Up @@ -5810,8 +5812,11 @@ log:
type: keyword
log.original:
dashed_name: log-original
description: 'This is the original log message and contains the full log message
before splitting it up in multiple parts.
description: 'Deprecated for removal in next major version release. This field
is superseded by `event.original`.

This is the original log message and contains the full log message before
splitting it up in multiple parts.

In contrast to the `message` field which can contain an extracted part of
the log message, this field contains the original, full log message. It can
Expand All @@ -5828,7 +5833,8 @@ log:
level: core
name: original
normalize: []
short: Original log message with light interpretation only (encoding, newlines).
short: Deprecated original log message with light interpretation only (encoding,
newlines).
type: keyword
log.syslog:
dashed_name: log-syslog
Expand Down
8 changes: 5 additions & 3 deletions schemas/event.yml
Original file line number Diff line number Diff line change
Expand Up @@ -587,12 +587,14 @@
dst=2.1.2.2spt=1232"
short: Raw text message of entire event.
description: >
Raw text message of entire event. Used to demonstrate log integrity.
Raw text message of entire event. Used to demonstrate log integrity
or where the full log message (before splitting it up in multiple
parts) may be required, e.g. for reindex.

This field is not indexed and doc_values are disabled. It cannot be
searched, but it can be retrieved from `_source`. If users wish to
override this and index this field, consider using the wildcard
data type.
override this and index this field, please see `Field data types`
in the `Elasticsearch Reference`.
index: false
doc_values: false

Expand Down
5 changes: 4 additions & 1 deletion schemas/log.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,11 @@
example: "Sep 19 08:26:10 localhost My log"
index: false
doc_values: false
short: Original log message with light interpretation only (encoding, newlines).
short: Deprecated original log message with light interpretation only (encoding, newlines).
description: >
Deprecated for removal in next major version release. This field is superseded by
`event.original`.

This is the original log message and contains the full log message
before splitting it up in multiple parts.

Expand Down

0 comments on commit 12a894e

Please sign in to comment.