Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for service.version #168

Merged
merged 4 commits into from
Apr 28, 2022

Conversation

tobiasstadler
Copy link
Contributor

@tobiasstadler tobiasstadler commented Feb 18, 2022

See #132. For the reference, I did not have a look at the implementation in #132.

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage Issues and PRs that need to be triaged labels Feb 18, 2022
@tobiasstadler
Copy link
Contributor Author

@eyalkoren I will add support for it in the agent once this is released.

@apmmachine
Copy link
Contributor

apmmachine commented Feb 18, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-28T04:35:04.980+0000

  • Duration: 7 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 232
Skipped 0
Total 232

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tobiasstadler
Copy link
Contributor Author

@eyalkoren Would you please have a look?

@tobiasstadler
Copy link
Contributor Author

ping

@szisiu szisiu mentioned this pull request Mar 30, 2022
@eyalkoren
Copy link
Contributor

@tobiasstadler sorry, we are quite overloaded atm, I hope we have a chance to get to this and additional ecs-logging stuff soon enough 🙏

@AlexanderWert AlexanderWert added this to the 8.3 milestone Apr 4, 2022
@AlexanderWert AlexanderWert removed the triage Issues and PRs that need to be triaged label Apr 4, 2022
Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasstadler Apologies for the long wait 🙏
Few very minor comments.
Please just bring up to date, then we'll test and merge.
Thanks for your patience!

docs/tab-widgets/ecs-encoder.asciidoc Outdated Show resolved Hide resolved
docs/tab-widgets/ecs-encoder.asciidoc Outdated Show resolved Hide resolved
@eyalkoren eyalkoren merged commit f8be7d2 into elastic:main Apr 28, 2022
@tobiasstadler tobiasstadler deleted the add-service-version branch April 29, 2022 05:26
@tobiasstadler
Copy link
Contributor Author

Thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants