Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument ecs-logging-java to set service name #1626

Closed
felixbarny opened this issue Jan 21, 2021 · 2 comments · Fixed by #3064
Closed

Instrument ecs-logging-java to set service name #1626

felixbarny opened this issue Jan 21, 2021 · 2 comments · Fixed by #3064
Assignees
@SylvainJuge
Labels
agent-java enhancement Enhancement of an existing feature instrumentation Instrumentation: framework support, custom plugins, ... logging application logging instrumentation and support
Milestone
8.8

Comments

@felixbarny
Copy link
Member

When ecs-logging-java is used in an application, we should instrument the constructor of the formatter/encoder to set the service name that has been configured for the agent if it has not been explicitly set in the logging configuration.
@AlexanderWert AlexanderWert modified the milestone: 7.12 Jan 21, 2021
@SylvainJuge SylvainJuge added instrumentation Instrumentation: framework support, custom plugins, ... logging application logging instrumentation and support enhancement Enhancement of an existing feature labels Jan 27, 2021
@AlexanderWert AlexanderWert modified the milestones: 7.12, 7.13, 7.14 Mar 24, 2021
@AlexanderWert AlexanderWert modified the milestones: 7.14, 7.16 Aug 24, 2021
tobiasstadler added a commit to tobiasstadler/apm-agent-java that referenced this issue Nov 29, 2021
@tobiasstadler
Added support for setting the service name on Log4j2's EcsLayout (ela…
fb5c1cf 
…stic#1626)
@tobiasstadler tobiasstadler mentioned this issue Nov 29, 2021
Merged
9 tasks
@tobiasstadler tobiasstadler mentioned this issue Feb 17, 2022
Closed
@jackshirazi
Copy link
Contributor

@felixbarny have the PRs referenced (elastic/ecs-logging-java#168 and #2296) implemented what you intended for this, or is there more to do?

@jackshirazi
Copy link
Contributor

jackshirazi commented Nov 14, 2022 •
edited by SylvainJuge
Loading

Done for log4j 2.x, but not yet other logging frameworks

@AlexanderWert AlexanderWert added this to the 8.8 milestone Feb 6, 2023
@SylvainJuge SylvainJuge mentioned this issue Mar 21, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SylvainJuge SylvainJuge

Labels
agent-java enhancement Enhancement of an existing feature instrumentation Instrumentation: framework support, custom plugins, ... logging application logging instrumentation and support
Projects
None yet
Milestone
8.8
Development

Successfully merging a pull request may close this issue.

set service name & version in ecs-logging SylvainJuge/apm-agent-java
4 participants
@SylvainJuge @AlexanderWert @felixbarny @jackshirazi