This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
fix: do not override compose configurations when syncing from beats #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused the last element in a compose file with multiple services to override the first one
6 tasks
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 1 |
| Passed | 96 |
| Skipped | 19 |
| Total | 116 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / End-To-End Tests / metricbeat_integrations && ceph / ceph-master-97985eb-nautilus-centos-7-x86_64 sends metrics to Elasticsearch without errors – Integrations
|
Merging, as we are skipping ceph. See #635 |
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 25, 2021
…lastic#630) * fix: initialise variable within the inner scope This caused the last element in a compose file with multiple services to override the first one * chore: support passing target file when writing it * chore: write unit tests for the very basic behavior os sanitising compose files * chore: enrich unit test to cover processing multiple child items under a service
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 25, 2021
…lastic#630) * fix: initialise variable within the inner scope This caused the last element in a compose file with multiple services to override the first one * chore: support passing target file when writing it * chore: write unit tests for the very basic behavior os sanitising compose files * chore: enrich unit test to cover processing multiple child items under a service
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 25, 2021
…lastic#630) * fix: initialise variable within the inner scope This caused the last element in a compose file with multiple services to override the first one * chore: support passing target file when writing it * chore: write unit tests for the very basic behavior os sanitising compose files * chore: enrich unit test to cover processing multiple child items under a service
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 25, 2021
…lastic#630) * fix: initialise variable within the inner scope This caused the last element in a compose file with multiple services to override the first one * chore: support passing target file when writing it * chore: write unit tests for the very basic behavior os sanitising compose files * chore: enrich unit test to cover processing multiple child items under a service
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 25, 2021
…lastic#630) * fix: initialise variable within the inner scope This caused the last element in a compose file with multiple services to override the first one * chore: support passing target file when writing it * chore: write unit tests for the very basic behavior os sanitising compose files * chore: enrich unit test to cover processing multiple child items under a service
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 25, 2021
…lastic#630) * fix: initialise variable within the inner scope This caused the last element in a compose file with multiple services to override the first one * chore: support passing target file when writing it * chore: write unit tests for the very basic behavior os sanitising compose files * chore: enrich unit test to cover processing multiple child items under a service
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 25, 2021
…lastic#630) * fix: initialise variable within the inner scope This caused the last element in a compose file with multiple services to override the first one * chore: support passing target file when writing it * chore: write unit tests for the very basic behavior os sanitising compose files * chore: enrich unit test to cover processing multiple child items under a service
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jan 25, 2021
…lastic#630) * fix: initialise variable within the inner scope This caused the last element in a compose file with multiple services to override the first one * chore: support passing target file when writing it * chore: write unit tests for the very basic behavior os sanitising compose files * chore: enrich unit test to cover processing multiple child items under a service
mdelapenya
added a commit
that referenced
this pull request
Jan 25, 2021
…630) (#647) * fix: initialise variable within the inner scope This caused the last element in a compose file with multiple services to override the first one * chore: support passing target file when writing it * chore: write unit tests for the very basic behavior os sanitising compose files * chore: enrich unit test to cover processing multiple child items under a service
mdelapenya
added a commit
that referenced
this pull request
Jan 25, 2021
…630) (#648) * fix: initialise variable within the inner scope This caused the last element in a compose file with multiple services to override the first one * chore: support passing target file when writing it * chore: write unit tests for the very basic behavior os sanitising compose files * chore: enrich unit test to cover processing multiple child items under a service
mdelapenya
added a commit
that referenced
this pull request
Jan 25, 2021
…630) (#649) * fix: initialise variable within the inner scope This caused the last element in a compose file with multiple services to override the first one * chore: support passing target file when writing it * chore: write unit tests for the very basic behavior os sanitising compose files * chore: enrich unit test to cover processing multiple child items under a service
mdelapenya
added a commit
that referenced
this pull request
Jan 25, 2021
…630) (#646) * fix: initialise variable within the inner scope This caused the last element in a compose file with multiple services to override the first one * chore: support passing target file when writing it * chore: write unit tests for the very basic behavior os sanitising compose files * chore: enrich unit test to cover processing multiple child items under a service
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It moves the variable holding the references to a single service into the loop-for that is responsible of creating the service.
In the process, we added unit tests to the sanitize compose file feature, and for that we had to change method signature to support writing to a different file in the test side (adding testability).
Why is it important?
We noticed that ceph was not receiving all the ports declared in its docker-compose file:
In the contrary it was overriden by the second service in the compose, ceph-api:
And this could lead to unexpected errors.
Checklist
make noticein the proper directory)Author's Checklist
How to test this PR locally
Related issues
Follow-ups
We should check https://github.com/elastic/beats/blob/master/metricbeat/module/ceph/docker-compose.yml#L5-L16, as it seems there is a hardcoded value for the image in ceph-api.