Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use supported-versions variables in ceph-api #23602

Closed
wants to merge 1 commit into from

Conversation

mdelapenya
Copy link
Contributor

@mdelapenya mdelapenya commented Jan 20, 2021

What does this PR do?

It uses the supported-versions env variables for the ceph-api service in the docker-compose.yml file for the integration.

Why is it important?

It seems values are hardcoded, and that could be affecting the E2E tests.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Related issues

@mdelapenya mdelapenya self-assigned this Jan 20, 2021
@mdelapenya mdelapenya added the Team:Automation Label for the Observability productivity team label Jan 20, 2021
@mdelapenya mdelapenya requested a review from a team January 20, 2021 21:47
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 20, 2021
@mdelapenya mdelapenya requested review from jsoriano and mtojek January 20, 2021 21:47
@@ -13,11 +13,11 @@ services:
- 8003
- 8080
ceph-api:
image: docker.elastic.co/integrations-ci/beats-ceph:master-6373c6a-jewel-centos-7-x86_64-1
image: docker.elastic.co/integrations-ci/beats-ceph:${CEPH_VERSION:-master-97985eb-nautilus-centos-7-x86_64}-1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this image is version -1 and the regular ceph is -2. @jsoriano could you please 👀 here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we wanted to keep using an specific version here, that is different to the one in the ceph service.

@mdelapenya mdelapenya added the Team:Integrations Label for the Integrations team label Jan 20, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 20, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-02-03T10:19:34.712+0000

  • Duration: 96 min 17 sec

  • Commit: 9348ab3

Test stats 🧪

Test Results
Failed 0
Passed 9464
Skipped 2443
Total 11907

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@@ -13,11 +13,11 @@ services:
- 8003
- 8080
ceph-api:
image: docker.elastic.co/integrations-ci/beats-ceph:master-6373c6a-jewel-centos-7-x86_64-1
image: docker.elastic.co/integrations-ci/beats-ceph:${CEPH_VERSION:-master-97985eb-nautilus-centos-7-x86_64}-1
Copy link
Member

@jsoriano jsoriano Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can use the same versions in both cases, if I remember well, we kept this here to keep some tests specifically running against some specific older version.

I was wondering how is it possible then that tests pass after the changes in this PR, and I have found that there isn't actually anything using at the moment the ceph-api service. It is not used in the python system tests, and go integration tests are skipped as flaky: #22612

Changes here probably need to be deeper, and maybe not only on the testing side. I think that we need to fix the integration tests and check what system tests are actually testing. Maybe at the end we can use a single ceph service, but we need to make E2E and go integration tests smarter so they know what metricsets they should be using for each versions. This is what the system tests seem to be doing.

Or maybe we can refactor the metricsets so they detect the version and do nothing if they implement collection methods that are not supported. This way we could enable all metricsets with any version. But I'd say that changes in this module have low priority at the moment.

@@ -13,11 +13,11 @@ services:
- 8003
- 8080
ceph-api:
image: docker.elastic.co/integrations-ci/beats-ceph:master-6373c6a-jewel-centos-7-x86_64-1
image: docker.elastic.co/integrations-ci/beats-ceph:${CEPH_VERSION:-master-97985eb-nautilus-centos-7-x86_64}-1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we wanted to keep using an specific version here, that is different to the one in the ceph service.

@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2021

This pull request does not have a backport label. Could you fix it @mdelapenya? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Sep 22, 2021
@jlind23
Copy link
Collaborator

jlind23 commented Mar 31, 2022

PRs grooming - Closing for now until further updates.

@jlind23 jlind23 closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:Automation Label for the Observability productivity team Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants