Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

fix: double quote tags if they are set #531

Merged
merged 2 commits into from
Dec 4, 2020
Merged

fix: double quote tags if they are set #531

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
005dc17
fix: double quote tags if they are set
mdelapenya Dec 4, 2020
08620c5
chore: control skip tags too
mdelapenya Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion e2e/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@ ifeq ($(SKIP_SCENARIOS),true)
## We always want to skip scenarios tagged with @skip
TAGS+= && ~skip
endif

# Double quote only if the tags are set
TAGS_VALUE="$(TAGS)"
else
ifeq ($(SKIP_SCENARIOS),true)
TAGS_FLAG=--tags
TAGS_VALUE="~skip"
endif
endif

GO_IMAGE_TAG?='stretch'
Expand Down Expand Up @@ -54,7 +62,7 @@ functional-test: install-godog
TIMEOUT_FACTOR=${TIMEOUT_FACTOR} \
STACK_VERSION=${STACK_VERSION} \
DEVELOPER_MODE=${DEVELOPER_MODE} \
godog --format=${FORMAT} ${TAGS_FLAG} "${TAGS}"
godog --format=${FORMAT} ${TAGS_FLAG} ${TAGS_VALUE}

.PHONY: lint
lint:
Expand Down