This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It double-quotes the tags in Makefile only when they are set
Why is it important?
There was a corner case when using Make to run all scenarios (not filtering by tag)
Checklist
make notice
in the proper directory)How to test this PR locally
Before this change, this command failed because godog was trying to evaluate "" as a feature path. Now it runs all scenarios (no TAGS set) but those skipped.
SUITE="fleet" DEVELOPER_MODE=false TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE make -C e2e functional-test
This command runs all scenarios (no TAGS set), including skipped.
SUITE="fleet" SKIP_SCENARIOS=false DEVELOPER_MODE=false TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE make -C e2e functional-test
This command runs some scenarios (TAGS is set), excluding skipped.
This command runs some scenarios (TAGS is set), including skipped.
Related issues