Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

fix: double quote tags if they are set #531

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

mdelapenya
Copy link
Contributor

@mdelapenya mdelapenya commented Dec 4, 2020

What does this PR do?

It double-quotes the tags in Makefile only when they are set

Why is it important?

There was a corner case when using Make to run all scenarios (not filtering by tag)

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

How to test this PR locally

Before this change, this command failed because godog was trying to evaluate "" as a feature path. Now it runs all scenarios (no TAGS set) but those skipped.

 SUITE="fleet" DEVELOPER_MODE=false TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE make -C e2e functional-test

This command runs all scenarios (no TAGS set), including skipped.

 SUITE="fleet" SKIP_SCENARIOS=false DEVELOPER_MODE=false TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE make -C e2e functional-test

This command runs some scenarios (TAGS is set), excluding skipped.

 SUITE="fleet" TAGS="fleet_mode_agent" DEVELOPER_MODE=false TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE make -C e2e functional-test

This command runs some scenarios (TAGS is set), including skipped.

 SUITE="fleet" TAGS="fleet_mode_agent" SKIP_SCENARIOS=false DEVELOPER_MODE=false TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE make -C e2e functional-test

Related issues

@mdelapenya mdelapenya self-assigned this Dec 4, 2020
@mdelapenya mdelapenya requested a review from a team December 4, 2020 14:48
@mdelapenya mdelapenya requested a review from EricDavisX December 4, 2020 14:53
@mdelapenya mdelapenya added automation bug Something isn't working labels Dec 4, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 4, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #531 updated

  • Start Time: 2020-12-04T14:53:25.193+0000

  • Duration: 5 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 32
Skipped 13
Total 45

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 32
Skipped 13
Total 45

@mdelapenya mdelapenya marked this pull request as ready for review December 4, 2020 15:04
@mdelapenya mdelapenya merged commit 9f6fa62 into elastic:master Dec 4, 2020
@mdelapenya mdelapenya deleted the 408-fix-empty-tags branch December 4, 2020 15:09
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Dec 4, 2020
* fix: double quote tags if they are set

* chore: control skip tags too
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Dec 4, 2020
* fix: double quote tags if they are set

* chore: control skip tags too
mdelapenya added a commit that referenced this pull request Dec 4, 2020
* fix: double quote tags if they are set

* chore: control skip tags too
mdelapenya added a commit that referenced this pull request Dec 4, 2020
* fix: double quote tags if they are set

* chore: control skip tags too
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using 'make' to run e2e tests without specifying a TAGS= value results in no tests being run
3 participants