Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #7890 to 6.4: Add missing namespace field in http server metricset #9072

Closed
wants to merge 1 commit into from

Conversation

jsoriano
Copy link
Member

Cherry-pick of PR #7890 to 6.4 branch. Original message:

This PR adds back the missing metricset.namespace field in to payloads generated by http server.

This PR adds back the missing `metricset.namespace` field in to payloads generated by http server.

(cherry picked from commit 08dfd03)
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM but I wonder now that 6.5 is out if we should backport it to 6.4.

Needs a rebase.

@jsoriano
Copy link
Member Author

Yeah, ok, probably not needed, closing this by now.

@jsoriano jsoriano closed this Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants