Add missing namespace field in http server metricset #7890
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
vjsamuel
force-pushed
the
add_back_http_namespace
branch
from
7ce51e8 to
62c1c67
Compare
There was a problem hiding this comment.
Could you update the data.json file? https://github.com/elastic/beats/blob/master/metricbeat/module/http/server/_meta/data.json
| @@ -83,10 +84,10 @@ func (m *MetricSet) Run(reporter mb.PushReporterV2) { | |||
| reporter.Error(err) | |||
| } else { | |||
| event := mb.Event{} | |||
| event.ModuleFields = common.MapStr{} | |||
| metricSetName := fields[mb.NamespaceKey].(string) | |||
| ns := fields[mb.NamespaceKey].(string) | |||
There was a problem hiding this comment.
Could you add an , ok check to make sure type conversion works?
| delete(fields, mb.NamespaceKey) | ||
| event.ModuleFields.Put(metricSetName, fields) | ||
| event.MetricSetFields = fields |
There was a problem hiding this comment.
Did you check if this has the expected outcome? Will this put it always under server or the namespace set below?
There was a problem hiding this comment.
it will put under the http.<namespace>
vjsamuel
force-pushed
the
add_back_http_namespace
branch
from
62c1c67 to
e506836
Compare
|
@ruflin the |
| if ok { | ||
| ns = fmt.Sprintf("http.%s", ns) | ||
| delete(fields, mb.NamespaceKey) | ||
| } else { |
There was a problem hiding this comment.
Why do you have an else here?
vjsamuel
force-pushed
the
add_back_http_namespace
branch
from
e506836 to
95a9c47
Compare
vjsamuel
force-pushed
the
add_back_http_namespace
branch
from
95a9c47 to
dacaa08
Compare
|
@ruflin should be backport to 6.x ? |
|
Yes, I'd say we should backport it, I'll do it. |
This PR adds back the missing `metricset.namespace` field in to payloads generated by http server. (cherry picked from commit 08dfd03)
This PR adds back the missing `metricset.namespace` field in to payloads generated by http server. (cherry picked from commit 08dfd03)
This PR adds back the missing `metricset.namespace` field in to payloads generated by http server. (cherry picked from commit 08dfd03)
This PR adds back the missing `metricset.namespace` field in to payloads generated by http server. (cherry picked from commit 08dfd03) Co-authored-by: Vijay Samuel <[email protected]>
This PR adds back the missing `metricset.namespace` field in to payloads generated by http server. (cherry picked from commit 08dfd03) Co-authored-by: Vijay Samuel <[email protected]>
…lastic#9071) This PR adds back the missing `metricset.namespace` field in to payloads generated by http server. (cherry picked from commit 21e1600) Co-authored-by: Vijay Samuel <[email protected]>
This PR adds back the missing
metricset.namespacefield in to payloads generated by http server.