Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.17](backport #42053) Changed CreationDate to string to prevent scientific notation conversion #42072

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[8.17](backport #42053) Changed CreationDate to string to prevent scientific notation conversion #42072

merged 1 commit into from
Dec 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 17, 2024

Proposed commit message

Changed CreationDate field internally from int to string - the marshalling of the string leads to scientific notation on some versions. Keeping it as string makes sure the value is passed as-is.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.
This is an automatic backport of pull request #42053 done by [Mergify](https://mergify.com).

@3kt @mergify
Changed CreationDate to string to prevent scientific notation convers…
7bd09e1 
…ion (#42053)

* Changed CreationDate to string to prevent scientific notation conversion

* Added changelog entry

* Make update

(cherry picked from commit b185b11)
@mergify mergify bot added the backport label Dec 17, 2024
@mergify mergify bot requested a review from a team as a code owner December 17, 2024 09:54
@mergify mergify bot assigned 3kt Dec 17, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 17, 2024
@botelastic
Copy link

botelastic bot commented Dec 17, 2024

This pull request doesn't have a Team:<team> label.

@3kt 3kt requested a review from consulthys December 17, 2024 11:36
consulthys
consulthys approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@consulthys consulthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT Stack Monitoring

@3kt 3kt merged commit ebc4877 into 8.17 Dec 17, 2024
32 checks passed
@3kt 3kt deleted the mergify/bp/8.17/pr-42053 branch December 17, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consulthys consulthys consulthys approved these changes

Assignees

@3kt 3kt

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@consulthys @3kt