Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed CreationDate to string to prevent scientific notation conversion #42053

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Changed CreationDate to string to prevent scientific notation conversion #42053

merged 4 commits into from
Dec 17, 2024
+3 −6

Conversation

3kt
Copy link
Contributor

@3kt 3kt commented Dec 16, 2024 •
edited
Loading

Proposed commit message

Changed CreationDate field internally from int to string - the marshalling of the string leads to scientific notation on some versions. Keeping it as string makes sure the value is passed as-is.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@3kt 3kt added bug backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify labels Dec 16, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 16, 2024
@mergify mergify bot assigned 3kt Dec 16, 2024
@3kt 3kt requested a review from consulthys December 16, 2024 14:58
@3kt 3kt added the Team:Monitoring Stack Monitoring team label Dec 16, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 16, 2024
@3kt 3kt marked this pull request as ready for review December 17, 2024 09:34
@3kt 3kt requested a review from a team as a code owner December 17, 2024 09:34
consulthys
consulthys approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@consulthys consulthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT Stack Monitoring

@3kt 3kt merged commit b185b11 into elastic:main Dec 17, 2024
32 checks passed
mergify bot pushed a commit that referenced this pull request Dec 17, 2024
@3kt @mergify
Changed CreationDate to string to prevent scientific notation convers…
46c4d95 
…ion (#42053)

* Changed CreationDate to string to prevent scientific notation conversion

* Added changelog entry

* Make update

(cherry picked from commit b185b11)
mergify bot pushed a commit that referenced this pull request Dec 17, 2024
@3kt @mergify
Changed CreationDate to string to prevent scientific notation convers…
7bd09e1 
…ion (#42053)

* Changed CreationDate to string to prevent scientific notation conversion

* Added changelog entry

* Make update

(cherry picked from commit b185b11)
This was referenced Dec 17, 2024
Merged
Merged
3kt added a commit that referenced this pull request Dec 17, 2024
@mergify @3kt
Changed CreationDate to string to prevent scientific notation convers…
70d840f 
…ion (#42053) (#42071)

* Changed CreationDate to string to prevent scientific notation conversion

* Added changelog entry

* Make update

(cherry picked from commit b185b11)

Co-authored-by: Alexis Charveriat <[email protected]>
3kt added a commit that referenced this pull request Dec 17, 2024
@mergify @3kt
Changed CreationDate to string to prevent scientific notation convers…
ebc4877 
…ion (#42053) (#42072)

* Changed CreationDate to string to prevent scientific notation conversion

* Added changelog entry

* Make update

(cherry picked from commit b185b11)

Co-authored-by: Alexis Charveriat <[email protected]>
@3kt 3kt deleted the fix_elasticsearch_module branch December 17, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@consulthys consulthys consulthys approved these changes

Assignees

@3kt 3kt

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify bug Team:Monitoring Stack Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3kt @consulthys