Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16](backport #41097) [vSphere] Add id field to all the metricsets #41700

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 20, 2024

Description

Added id field to all the metricsets.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues


This is an automatic backport of pull request #41097 done by [Mergify](https://mergify.com).

* add id field

* update changelog

* fix unit test

* update field descriptions

* update fields.asci

* fix lint

* address review comments

* update fields.asci

(cherry picked from commit ec92e02)
@mergify mergify bot added the backport label Nov 20, 2024
@mergify mergify bot requested a review from a team as a code owner November 20, 2024 10:22
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 20, 2024
@kush-elastic kush-elastic added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Nov 20, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 20, 2024
Copy link
Contributor

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated backport.
Approving!

@kush-elastic kush-elastic merged commit 167f545 into 8.16 Nov 21, 2024
32 checks passed
@kush-elastic kush-elastic deleted the mergify/bp/8.16/pr-41097 branch November 21, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants