[vSphere] Add id field to all the metricsets #41097

niraj-elastic · 2024-10-03T12:28:57Z

Description

Added id field to all the metricsets.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes https://github.com/elastic/obs-integration-team/issues/73

mergify · 2024-10-03T12:29:33Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @niraj-elastic? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

mergify · 2024-10-03T12:29:34Z

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

harnish-elastic

Minor nits. Otherwise LGTM!

metricbeat/module/vsphere/datastorecluster/_meta/fields.yml

metricbeat/module/vsphere/resourcepool/_meta/fields.yml

lucian-ioan

LGTM

kush-elastic

LGTM

ishleenk17 · 2024-10-18T05:58:48Z

CHANGELOG.next.asciidoc

@@ -370,6 +370,7 @@ https://github.com/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff]
 - Added Cisco Meraki module {pull}40836[40836]
 - Added Palo Alto Networks module {pull}40686[40686]
 - Restore docker.network.in.* and docker.network.out.* fields in docker module {pull}40968[40968]
+- Add `id` field to all the vSphere metricsets. {pill}41097[41097]


Suggested change

- Add `id` field to all the vSphere metricsets. {pill}41097[41097]

- Add `id` field to all the vSphere metricsets. {pull}41097[41097]

ishleenk17 · 2024-10-18T05:59:56Z

metricbeat/docs/fields.asciidoc

+*`vsphere.virtualmachine.id`*::
+
+--
+Virtual machine ID.


Suggested change

Virtual machine ID.

Unique virtual machine ID.

ishleenk17 · 2024-10-18T06:01:53Z

metricbeat/module/vsphere/host/_meta/fields.yml

+    - name: id
+      type: keyword
+      description: >
+        Unique Host ID.


Suggested change

Unique Host ID.

Unique host ID.

mergify · 2024-10-18T15:23:31Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b vsphere_add_id_field upstream/vsphere_add_id_field
git merge upstream/main
git push upstream vsphere_add_id_field

…phere_add_id_field

ishleenk17

Looks good!

* add id field * update changelog * fix unit test * update field descriptions * update fields.asci * fix lint * address review comments * update fields.asci (cherry picked from commit ec92e02)

* add id field * update changelog * fix unit test * update field descriptions * update fields.asci * fix lint * address review comments * update fields.asci (cherry picked from commit ec92e02) Co-authored-by: niraj-elastic <[email protected]>

* add id field * update changelog * fix unit test * update field descriptions * update fields.asci * fix lint * address review comments * update fields.asci (cherry picked from commit ec92e02)

…41700) * [vSphere] Add id field to all the metricsets (#41097) * add id field * update changelog * fix unit test * update field descriptions * update fields.asci * fix lint * address review comments * update fields.asci (cherry picked from commit ec92e02) * fix changelog --------- Co-authored-by: niraj-elastic <[email protected]> Co-authored-by: Kush Rana <[email protected]>

add id field

29dce1c

niraj-elastic added enhancement Metricbeat Metricbeat Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Oct 3, 2024

niraj-elastic self-assigned this Oct 3, 2024

niraj-elastic requested a review from a team as a code owner October 3, 2024 12:28

botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 3, 2024

mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 3, 2024

update changelog

0ec2ebb

niraj-elastic requested review from kush-elastic and ishleenk17 October 3, 2024 12:33

harnish-elastic approved these changes Oct 7, 2024

View reviewed changes

metricbeat/module/vsphere/datastorecluster/_meta/fields.yml Outdated Show resolved Hide resolved

metricbeat/module/vsphere/resourcepool/_meta/fields.yml Outdated Show resolved Hide resolved

lucian-ioan approved these changes Oct 10, 2024

View reviewed changes

fix unit test

4291d4c

kush-elastic approved these changes Oct 14, 2024

View reviewed changes

niraj-elastic and others added 4 commits October 14, 2024 15:34

update field descriptions

e3d8ba2

Merge branch 'main' into vsphere_add_id_field

88e5774

update fields.asci

5cc672f

fix lint

86b98cd

ishleenk17 reviewed Oct 18, 2024

View reviewed changes

niraj-elastic added 3 commits October 21, 2024 11:53

Merge branch 'main' of https://github.com/niraj-elastic/beats into vs…

f5f5bcf

…phere_add_id_field

address review comments

0dae46b

update fields.asci

bb7160e

niraj-elastic requested a review from ishleenk17 October 21, 2024 09:04

ishleenk17 approved these changes Oct 21, 2024

View reviewed changes

Merge branch 'main' into vsphere_add_id_field

362d8de

niraj-elastic merged commit ec92e02 into elastic:main Oct 22, 2024
32 checks passed

mergify bot mentioned this pull request Oct 22, 2024

[8.x](backport #41097) [vSphere] Add id field to all the metricsets #41359

Merged

4 tasks

kush-elastic added the backport-8.16 Automated backport with mergify label Nov 20, 2024

mergify bot mentioned this pull request Nov 20, 2024

[8.16](backport #41097) [vSphere] Add id field to all the metricsets #41700

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vSphere] Add id field to all the metricsets #41097

[vSphere] Add id field to all the metricsets #41097

niraj-elastic commented Oct 3, 2024

mergify bot commented Oct 3, 2024

mergify bot commented Oct 3, 2024

harnish-elastic left a comment

lucian-ioan left a comment

kush-elastic left a comment

ishleenk17 Oct 18, 2024

ishleenk17 Oct 18, 2024

ishleenk17 Oct 18, 2024

mergify bot commented Oct 18, 2024

ishleenk17 left a comment

	- Add `id` field to all the vSphere metricsets. {pill}41097[41097]
	- Add `id` field to all the vSphere metricsets. {pull}41097[41097]

[vSphere] Add id field to all the metricsets #41097

[vSphere] Add id field to all the metricsets #41097

Conversation

niraj-elastic commented Oct 3, 2024

Description

Checklist

Related issues

mergify bot commented Oct 3, 2024

mergify bot commented Oct 3, 2024

harnish-elastic left a comment

Choose a reason for hiding this comment

lucian-ioan left a comment

Choose a reason for hiding this comment

kush-elastic left a comment

Choose a reason for hiding this comment

ishleenk17 Oct 18, 2024

Choose a reason for hiding this comment

ishleenk17 Oct 18, 2024

Choose a reason for hiding this comment

ishleenk17 Oct 18, 2024

Choose a reason for hiding this comment

mergify bot commented Oct 18, 2024

ishleenk17 left a comment

Choose a reason for hiding this comment