Global processor reload #40312
Draft
Global processor reload #40312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delay instantiation of Pipeline object till the first client (input) tries to connect to it. The idea is to use a builder object for the Pipeline on which we can set parameters (in this case the global processor config) until the Pipeline is instantiated. Once the Pipeline is instantiated, the global processor reloader will return a specific error, signaling that to reload configuration we need a new Pipeline (i.e. a beat restart). At this point in the code the reload and restart seem to work, however it seems that the output unit is not set correctly (we probably need some additional hook to correctly wire the Pipeline and the Output object
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
pchila
added
the
Team:Elastic-Agent-Control-Plane
botelastic
bot
removed
the
needs_team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Alternative approach derived from PR #40091 .
To reload the global processor we delay instantiating the Pipeline object similarly to what's done with output: we allow to load using settings from the control protocol exactly once; if more changes come in a restart of the beat is required.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs