Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global processors reload #40091

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

pchila
Copy link
Member

@pchila pchila commented Jul 3, 2024

Proposed commit message

This PR attempts to load global processor configuration from the control protocol to allow for some control when running under elastic-agent.

Please have a look at elastic/elastic-agent-client#117 and elastic/elastic-agent#5052 for the client and elastic-agent changes respectively.

In this PR I added:

  • a tracking of the clients connected to the pipeline object
  • a reload mechanism for the global processor configuration

What is still missing:

  • a proper way of pausing the processing for a moment and perform a call on each pipeline client to set the new global processor on each

This PR has been on hold as the solution look a bit too complicated and there are risks of deadlocks (think about Pipeline trying to set processor on a client that is trying to publish on the same Pipeline) and a different approach has been drafted in another PR based on this one

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 3, 2024
@pchila pchila added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Jul 3, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 3, 2024
@pchila pchila added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 3, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 3, 2024
@mergify mergify bot assigned pchila Jul 3, 2024
Copy link
Contributor

mergify bot commented Jul 3, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @pchila? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant