Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Winlogbeat: post-migration cleanup #39154

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Winlogbeat: post-migration cleanup #39154

merged 2 commits into from
Apr 24, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Apr 23, 2024 •
edited
Loading

Proposed commit message

In scope of https://github.com/elastic/ingest-dev/issues/3072 - removed winhlogbeat from pull-requests.json and common script
BK Builds: https://buildkite.com/elastic/beats-winlogbeat/builds?branch=oakrizan%3Awinlogbeat-fixes

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@oakrizan oakrizan added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify Team:Ingest-EngProd backport-v8.14.0 Automated backport with mergify labels Apr 23, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 23, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 23, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 13 min 8 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@dliappis
Copy link
Contributor

/package

@oakrizan oakrizan force-pushed the winlogbeat-fixes branch 3 times, most recently from 3baa0cd to 069b604 Compare April 24, 2024 05:54
@oakrizan oakrizan marked this pull request as ready for review April 24, 2024 07:28
@oakrizan oakrizan requested a review from a team as a code owner April 24, 2024 07:28
dliappis
dliappis reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also remove the duplicate entry for winlogbeat from https://github.com/elastic/beats/blob/main/.buildkite/hooks/pre-command#L62

@dliappis dliappis self-requested a review April 24, 2024 12:13
dliappis
dliappis approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oakrizan oakrizan merged commit c9b58e2 into elastic:main Apr 24, 2024
103 of 106 checks passed
mergify bot pushed a commit that referenced this pull request Apr 24, 2024
@oakrizan @mergify
Winlogbeat: post-migration cleanup (#39154)
90c0de5 
* removed winlogbeat from pull-requests json & comon script

* removed winlogbeat duplicated record

(cherry picked from commit c9b58e2)

# Conflicts:
#	.buildkite/pull-requests.json
@mergify mergify bot mentioned this pull request Apr 24, 2024
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Apr 24, 2024
@oakrizan @mergify
Winlogbeat: post-migration cleanup (#39154)
42c93ba 
* removed winlogbeat from pull-requests json & comon script

* removed winlogbeat duplicated record

(cherry picked from commit c9b58e2)

# Conflicts:
#	.buildkite/pull-requests.json
@mergify mergify bot mentioned this pull request Apr 24, 2024
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Apr 24, 2024
@oakrizan @mergify
Winlogbeat: post-migration cleanup (#39154)
47edd03 
* removed winlogbeat from pull-requests json & comon script

* removed winlogbeat duplicated record

(cherry picked from commit c9b58e2)
@mergify mergify bot mentioned this pull request Apr 24, 2024
Merged
6 tasks
@alexsapran alexsapran mentioned this pull request Apr 24, 2024
Merged
9 tasks
oakrizan added a commit that referenced this pull request Apr 25, 2024
@oakrizan
Winlogbeat: post-migration cleanup (#39154)
816564c 
* removed winlogbeat from pull-requests json & comon script

* removed winlogbeat duplicated record

(cherry picked from commit c9b58e2)
oakrizan added a commit that referenced this pull request Apr 25, 2024
@oakrizan
Winlogbeat: post-migration cleanup (#39154)
d14c063 
* removed winlogbeat from pull-requests json & comon script

* removed winlogbeat duplicated record

(cherry picked from commit c9b58e2)

# Conflicts:
#	.buildkite/pull-requests.json
oakrizan added a commit that referenced this pull request Apr 25, 2024
@oakrizan
Winlogbeat: post-migration cleanup (#39154)
789b556 
* removed winlogbeat from pull-requests json & comon script

* removed winlogbeat duplicated record

(cherry picked from commit c9b58e2)

# Conflicts:
#	.buildkite/pull-requests.json
oakrizan added a commit that referenced this pull request Apr 25, 2024
@oakrizan
Winlogbeat: post-migration cleanup (#39154)
605c068 
* removed winlogbeat from pull-requests json & comon script

* removed winlogbeat duplicated record

(cherry picked from commit c9b58e2)

# Conflicts:
#	.buildkite/pull-requests.json
oakrizan added a commit that referenced this pull request Apr 25, 2024
@oakrizan
Winlogbeat: post-migration cleanup (#39154)
40dd20c 
* removed winlogbeat from pull-requests json & comon script

* removed winlogbeat duplicated record

(cherry picked from commit c9b58e2)
oakrizan added a commit that referenced this pull request Apr 25, 2024
@oakrizan
Winlogbeat: post-migration cleanup (#39154)
3f11970 
* removed winlogbeat from pull-requests json & comon script

* removed winlogbeat duplicated record

(cherry picked from commit c9b58e2)

# Conflicts:
#	.buildkite/pull-requests.json
oakrizan added a commit that referenced this pull request Apr 26, 2024
@oakrizan
Winlogbeat: post-migration cleanup (#39154)
24e04c9 
* removed winlogbeat from pull-requests json & comon script

* removed winlogbeat duplicated record

(cherry picked from commit c9b58e2)

# Conflicts:
#	.buildkite/pull-requests.json
oakrizan added a commit that referenced this pull request Apr 26, 2024
@oakrizan
Winlogbeat: post-migration cleanup (#39154)
4af4ceb 
* removed winlogbeat from pull-requests json & comon script

* removed winlogbeat duplicated record

(cherry picked from commit c9b58e2)
oakrizan added a commit that referenced this pull request Apr 26, 2024
@mergify @oakrizan
[8.13](backport #39154) Winlogbeat: post-migration cleanup (#39185)
7ef272c 
* Winlogbeat: post-migration cleanup (#39154)

* removed winlogbeat from pull-requests json & comon script

* removed winlogbeat duplicated record

(cherry picked from commit c9b58e2)

# Conflicts:
#	.buildkite/pull-requests.json

* resolved conflicts

---------

Co-authored-by: Olga Naydyonock <[email protected]>
oakrizan added a commit that referenced this pull request Apr 26, 2024
@mergify @oakrizan
[7.17](backport #39154) Winlogbeat: post-migration cleanup (#39184)
ef28eb7 
* Winlogbeat: post-migration cleanup (#39154)

* removed winlogbeat from pull-requests json & comon script

* removed winlogbeat duplicated record

(cherry picked from commit c9b58e2)

# Conflicts:
#	.buildkite/pull-requests.json

* resolved conflicts

---------

Co-authored-by: Olga Naydyonock <[email protected]>
Co-authored-by: Olga Naidjonoka <[email protected]>
oakrizan added a commit that referenced this pull request Apr 26, 2024
@mergify @oakrizan
Winlogbeat: post-migration cleanup (#39154) (#39186)
8b4936b 
* removed winlogbeat from pull-requests json & comon script

* removed winlogbeat duplicated record

(cherry picked from commit c9b58e2)

Co-authored-by: Olga Naydyonock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsapran alexsapran alexsapran approved these changes

@dliappis dliappis dliappis approved these changes

@pazone pazone Awaiting requested review from pazone

Assignees

@oakrizan oakrizan

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify Team:Ingest-EngProd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oakrizan @elasticmachine @dliappis @alexsapran