-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beats DRA pipeline #39126
Beats DRA pipeline #39126
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
.buildkite/scripts/dra.sh
Outdated
set -euo pipefail | ||
|
||
## TODO: Set to empty string when Jenkins is disabled | ||
DRY_RUN="--dry-run" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend we change it to
if [[ "$DRY_RUN" == "false" ]]; then echo "--- Running in publish mode"; DRY_RUN=""; else echo "--- Running in dry-run mode"; DRY_RUN="--dry-run"; fi
to facilitate easy testing.
IMPORTANT because DRY_RUN
maybe unset, we should also move set -euo pipefail
from line 2 right after the suggested conditional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Packaging pipieline resource * Revetred agentbeat pipeline deletion * Cleanup * Test auditbeat packaging pipeline * Fix steps keys * Fix steps keys * Fix env vars * Fix env vars * Fix env vars * Unified artifacts dir * Implemented DRA steps * Test filebeat * Test matrix * Aligned artifacts directories * Aligned artifacts directories * Aligned artifacts directories * Aligned artifacts directories * Debug * Debug * Package all beats * Test DRA snapshot * Test DRA snapshot * Rename artifacts * fix dashboards artifacts * Cleanup * cleanup * No need to install msi tools * Apply suggestions from code review Co-authored-by: Dimitrios Liappis <[email protected]> * Extraced platforms variables * Cleanup * Added RUN_SNAPSHOT condition * Cleanup * Boolean dry-run * Boolean dry-run --------- Co-authored-by: Dimitrios Liappis <[email protected]> (cherry picked from commit c6444db) # Conflicts: # .buildkite/packaging.pipeline.yml
* Packaging pipieline resource * Revetred agentbeat pipeline deletion * Cleanup * Test auditbeat packaging pipeline * Fix steps keys * Fix steps keys * Fix env vars * Fix env vars * Fix env vars * Unified artifacts dir * Implemented DRA steps * Test filebeat * Test matrix * Aligned artifacts directories * Aligned artifacts directories * Aligned artifacts directories * Aligned artifacts directories * Debug * Debug * Package all beats * Test DRA snapshot * Test DRA snapshot * Rename artifacts * fix dashboards artifacts * Cleanup * cleanup * No need to install msi tools * Apply suggestions from code review Co-authored-by: Dimitrios Liappis <[email protected]> * Extraced platforms variables * Cleanup * Added RUN_SNAPSHOT condition * Cleanup * Boolean dry-run * Boolean dry-run --------- Co-authored-by: Dimitrios Liappis <[email protected]> (cherry picked from commit c6444db) # Conflicts: # .buildkite/packaging.pipeline.yml
* Packaging pipieline resource * Revetred agentbeat pipeline deletion * Cleanup * Test auditbeat packaging pipeline * Fix steps keys * Fix steps keys * Fix env vars * Fix env vars * Fix env vars * Unified artifacts dir * Implemented DRA steps * Test filebeat * Test matrix * Aligned artifacts directories * Aligned artifacts directories * Aligned artifacts directories * Aligned artifacts directories * Debug * Debug * Package all beats * Test DRA snapshot * Test DRA snapshot * Rename artifacts * fix dashboards artifacts * Cleanup * cleanup * No need to install msi tools * Apply suggestions from code review Co-authored-by: Dimitrios Liappis <[email protected]> * Extraced platforms variables * Cleanup * Added RUN_SNAPSHOT condition * Cleanup * Boolean dry-run * Boolean dry-run --------- Co-authored-by: Dimitrios Liappis <[email protected]> (cherry picked from commit c6444db) # Conflicts: # .buildkite/packaging.pipeline.yml
This PR fixes a number of bugs from #39126
This PR fixes a number of bugs from #39126
This PR fixes a number of bugs from #39126
This PR fixes a number of bugs from #39126
* Beats DRA pipeline (#39126) * Packaging pipieline resource * Revetred agentbeat pipeline deletion * Cleanup * Test auditbeat packaging pipeline * Fix steps keys * Fix steps keys * Fix env vars * Fix env vars * Fix env vars * Unified artifacts dir * Implemented DRA steps * Test filebeat * Test matrix * Aligned artifacts directories * Aligned artifacts directories * Aligned artifacts directories * Aligned artifacts directories * Debug * Debug * Package all beats * Test DRA snapshot * Test DRA snapshot * Rename artifacts * fix dashboards artifacts * Cleanup * cleanup * No need to install msi tools * Apply suggestions from code review Co-authored-by: Dimitrios Liappis <[email protected]> * Extraced platforms variables * Cleanup * Added RUN_SNAPSHOT condition * Cleanup * Boolean dry-run * Boolean dry-run --------- Co-authored-by: Dimitrios Liappis <[email protected]> (cherry picked from commit c6444db) # Conflicts: # .buildkite/packaging.pipeline.yml * Fixes for Buildkite packaging pipeline (#39207) This PR fixes a number of bugs from #39126 * Fix BK DRA pipeline (#39212) This commit fixes the error "interpolating remaining fields: Expected identifier to start with a letter, got /" * Fix permissions for packaging (#39218) This commit fixes the release-manager error > # > java.io.FileNotFoundException: /artifacts/build/distributions/... (Permission denied) by adjusting the permissions of parent directories. Additionally there are a few logging enhancements to improve debugging, as well as the introduction of a new optional `DRA_BRANCH` environment variable, to help running and debugging via PRs. Relates https://github.com/elastic/ingest-dev/issues/3095 --------- Signed-off-by: Alexandros Sapranidis <[email protected]> Co-authored-by: Dimitrios Liappis <[email protected]> * Added DEV flag to snapshot. prepare-release-manager.sh staging param (#39217) Added DEV flag to snapshot builds. Specified the workflow for prepare-release-manager.sh Relates: https://github.com/elastic/ingest-dev/issues/3095 --------- Signed-off-by: Alexandros Sapranidis <[email protected]> Co-authored-by: Pavel Zorin <[email protected]> Co-authored-by: Dimitrios Liappis <[email protected]> Co-authored-by: Alexandros Sapranidis <[email protected]>
Add DRA Buildkite packaging pipelines for 8.13 --------- Signed-off-by: Alexandros Sapranidis <[email protected]> Co-authored-by: Dimitrios Liappis <[email protected]> Co-authored-by: Alexandros Sapranidis <[email protected]>(cherry picked from commit c6444db)
Add DRA Buildkite packaging pipelines for 7.17 --------- Signed-off-by: Alexandros Sapranidis <[email protected]> Co-authored-by: Pavel Zorin <[email protected]> Co-authored-by: Dimitrios Liappis <[email protected]> Co-authored-by: Alexandros Sapranidis <[email protected]>
@@ -0,0 +1,41 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I see this file is a copy of .ci/scripts/prepare-release-manager.sh
but .ci/scripts/prepare-release-manager.sh
has not been deleted...
Proposed commit message
Beats Packaging pipeline
Migrates packaging.groovy to buildkite.
Buildkite packaging pipeline is used to build and publish the packages for the Beats. The pipeline is triggered by a commit to the
main
or release branches.The pipeline definition is located in the
.buildkite/packaging.pipeline.yml
Triggers
Staging packaging DRA is triggered for the
main
and release branches.Snapshot can be triggered for any branch by the
/package
comment in the PR. The release-manager dry-run will be used for PR builds.Pipeline steps
Beats dashboards
Generates
build/distributions/dependencies.csv
and adds it to thebeats-dashboards
artifact. Thedependencies.csv
is required by the release-manager configurationPackaging snapshot/staging
mage package, mage ironbank
)build/distributions/<beat>/
directory and adds it as an artifact. Where<beat>
is the name of the beatbuild/distributions/<beat>/
directory, where<beat>
is the name of the beat. For example,auditbeat
, notx-pack/auditbeat
DRA publish
Downloads the artifacts from the
packaging snapshot/staging
step and publishes them to the Elastic DRA registry.Snapshot publishing example (Dry run)
Beats-tester and e2e tests are not triggered
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs