Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with x-pack/metricbeat not using base settings. #38959

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

blakerouse
Copy link
Contributor

Proposed commit message

Fixes issue where x-pack/metricbeat did not use the instance.Settings from the oss metricbeat. Required for the proper initialization functions to be called after the change for supporting agentbeat.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse blakerouse added Team:Elastic-Agent Label for the Agent team backport-skip Skip notification from the automated backport with mergify labels Apr 16, 2024
@blakerouse blakerouse self-assigned this Apr 16, 2024
@blakerouse blakerouse requested a review from a team as a code owner April 16, 2024 00:49
@blakerouse blakerouse requested review from belimawr and rdner April 16, 2024 00:49
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 16, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 16, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-04-16T06:39:22.462+0000

  • Duration: 52 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 1886
Skipped 133
Total 2019

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert requested review from fearful-symmetry and leehinman and removed request for belimawr April 16, 2024 12:45
@blakerouse blakerouse merged commit 3f1d32b into elastic:main Apr 16, 2024
37 checks passed
@blakerouse blakerouse deleted the fix-xpack-metricbeat branch April 16, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beats autodiscover error in 8.14.0-SNAPOSHOT
4 participants