Fix issue with x-pack/metricbeat not using base settings. (#38959)

Co-authored-by: Pierre HILBERT <[email protected]>

x-pack/metricbeat/cmd/root.go

@@ -5,14 +5,11 @@
 package cmd
 
 import (
-	"flag"
 	"fmt"
 
 	"github.com/spf13/cobra"
-	"github.com/spf13/pflag"
 
 	"github.com/elastic/beats/v7/libbeat/cmd"
-	"github.com/elastic/beats/v7/libbeat/cmd/instance"
 	"github.com/elastic/beats/v7/libbeat/ecs"
 	"github.com/elastic/beats/v7/libbeat/processors"
 	"github.com/elastic/beats/v7/libbeat/publisher/processing"
@@ -47,19 +44,13 @@ var withECSVersion = processing.WithFields(mapstr.M{
 })
 
 func init() {
-	var runFlags = pflag.NewFlagSet(Name, pflag.ExitOnError)
-	runFlags.AddGoFlag(flag.CommandLine.Lookup("system.hostfs"))
 	globalProcs, err := processors.NewPluginConfigFromList(defaultProcessors())
 	if err != nil { // these are hard-coded, shouldn't fail
 		panic(fmt.Errorf("error creating global processors: %w", err))
 	}
-	settings := instance.Settings{
-		RunFlags:        runFlags,
-		Name:            Name,
-		HasDashboards:   true,
-		ElasticLicensed: true,
-		Processing:      processing.MakeDefaultSupport(true, globalProcs, withECSVersion, processing.WithHost, processing.WithAgentMeta()),
-	}
+	settings := mbcmd.MetricbeatSettings()
+	settings.ElasticLicensed = true
+	settings.Processing = processing.MakeDefaultSupport(true, globalProcs, withECSVersion, processing.WithHost, processing.WithAgentMeta())
 	RootCmd = cmd.GenRootCmdWithSettings(beater.DefaultCreator(), settings)
 	RootCmd.AddCommand(cmd.GenModulesCmd(Name, "", mbcmd.BuildModulesManager))
 	RootCmd.TestCmd.AddCommand(test.GenTestModulesCmd(Name, "", beater.DefaultTestModulesCreator()))