Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.13](backport #38706) [AWS] Fix rds field description aws.rds.cpu.total.pct #38787

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 9, 2024

Proposed commit message

Based on the code where the RDS CPU metric is collected, this value is divided by 100: https://github.com/elastic/beats/blob/v8.10.2/x-pack/metricbeat/module/aws/cloudwatch/metadata/rds/rds.go#L40
Fixing the documentation to not say percentage in the field description.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

This is an automatic backport of pull request #38706 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner April 9, 2024 16:04
@mergify mergify bot added the backport label Apr 9, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 9, 2024
@botelastic
Copy link

botelastic bot commented Apr 9, 2024

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 9, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 72 min 24 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor Author

mergify bot commented Apr 15, 2024

This pull request has not been merged yet. Could you please review and merge it @kaiyan-sheng? 🙏

2 similar comments
Copy link
Contributor Author

mergify bot commented Apr 22, 2024

This pull request has not been merged yet. Could you please review and merge it @kaiyan-sheng? 🙏

Copy link
Contributor Author

mergify bot commented Apr 29, 2024

This pull request has not been merged yet. Could you please review and merge it @kaiyan-sheng? 🙏

@kaiyan-sheng kaiyan-sheng merged commit 712df71 into 8.13 Apr 30, 2024
45 checks passed
@kaiyan-sheng kaiyan-sheng deleted the mergify/bp/8.13/pr-38706 branch April 30, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants