Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] Fix rds field description aws.rds.cpu.total.pct #38706

Merged
merged 9 commits into from
Apr 9, 2024

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Apr 2, 2024

Proposed commit message

Based on the code where the RDS CPU metric is collected, this value is divided by 100: https://github.com/elastic/beats/blob/v8.10.2/x-pack/metricbeat/module/aws/cloudwatch/metadata/rds/rds.go#L40
Fixing the documentation to not say percentage in the field description.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner April 2, 2024 18:50
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 2, 2024
Copy link
Contributor

mergify bot commented Apr 2, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kaiyan-sheng? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@kaiyan-sheng kaiyan-sheng added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Apr 2, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 2, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 2, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-04-09T03:34:37.374+0000

  • Duration: 78 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 9875
Skipped 1605
Total 11480

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kaiyan-sheng kaiyan-sheng added backport-v8.12.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify labels Apr 9, 2024
@kaiyan-sheng kaiyan-sheng merged commit 7c4db8f into elastic:main Apr 9, 2024
79 of 80 checks passed
@kaiyan-sheng kaiyan-sheng deleted the rds_doc branch April 9, 2024 16:03
mergify bot pushed a commit that referenced this pull request Apr 9, 2024
mergify bot pushed a commit that referenced this pull request Apr 9, 2024
kaiyan-sheng added a commit that referenced this pull request Apr 30, 2024
…otal.pct (#38787)

* [AWS] Fix rds field description aws.rds.cpu.total.pct (#38706)

(cherry picked from commit 7c4db8f)

* run make update

---------

Co-authored-by: kaiyan-sheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.12.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants