-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Fix rds field description aws.rds.cpu.total.pct #38706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Apr 2, 2024
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
kaiyan-sheng
added
the
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
label
Apr 2, 2024
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Apr 2, 2024
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
constanca-m
approved these changes
Apr 9, 2024
kaiyan-sheng
added
backport-v8.12.0
Automated backport with mergify
backport-v8.13.0
Automated backport with mergify
labels
Apr 9, 2024
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
(cherry picked from commit 7c4db8f)
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
(cherry picked from commit 7c4db8f)
This was referenced Apr 9, 2024
kaiyan-sheng
added a commit
that referenced
this pull request
Apr 30, 2024
…otal.pct (#38787) * [AWS] Fix rds field description aws.rds.cpu.total.pct (#38706) (cherry picked from commit 7c4db8f) * run make update --------- Co-authored-by: kaiyan-sheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.12.0
Automated backport with mergify
backport-v8.13.0
Automated backport with mergify
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Based on the code where the RDS CPU metric is collected, this value is divided by 100: https://github.com/elastic/beats/blob/v8.10.2/x-pack/metricbeat/module/aws/cloudwatch/metadata/rds/rds.go#L40
Fixing the documentation to not say percentage in the field description.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.